[GitHub] [airflow] kaxil commented on a change in pull request #10230: Fix KubernetesPodOperator reattachment

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #10230:
URL: https://github.com/apache/airflow/pull/10230#discussion_r467472950



##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -304,14 +297,40 @@ def execute(self, context) -> Optional[str]:
         except AirflowException as ex:
             raise AirflowException('Pod Launching failed: {error}'.format(error=ex))
 
+    def handle_pod_overlap(self, labels, try_numbers_match, launcher, pod_list):
+        """
+
+        @param labels: labels used to determine if a pod is repeated
+        @type labels: dict
+        @param try_numbers_match: do the try numbers match? Only needed for logging purposes
+        @type try_numbers_match: bool
+        @param launcher: PodLauncher
+        @param pod_list: list of pods found
+        @return:

Review comment:
       ```suggestion
           :param labels: labels used to determine if a pod is repeated
           :type labels: dict
           :param try_numbers_match: do the try numbers match? Only needed for logging purposes
           :type try_numbers_match: bool
           :param launcher: PodLauncher
           :param pod_list: list of pods found
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org