You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dg4prez <gi...@git.apache.org> on 2017/04/18 21:18:08 UTC
[GitHub] incubator-trafficcontrol pull request #480: [TC-236] status page only shows ...
GitHub user dg4prez opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/480
[TC-236] status page only shows parent_pending for parents in same cdn as host
Updates status page used by ORT to determine if there are parents in a pending state to ignore cachegroup servers not in the same CDN.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dg4prez/incubator-trafficcontrol parent_pending_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/480.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #480
----
commit 738fb90114f458218d0d2dbd08a5bc43d18c485f
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-04-18T21:15:06Z
only shows parent_pending for parents with cdn_ids that match cdn_id of host
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #480: [TC-236] status page only shows ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/480
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #480: [TC-236] status page only shows ...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/480#discussion_r112088073
--- Diff: traffic_ops/app/lib/UI/Server.pm ---
@@ -912,12 +912,12 @@ sub readupdate {
my $rs_parents = $self->db->resultset('Server')->search( { cachegroup => $parent_cg }, { prefetch => [ 'status'] } );
--- End diff --
That makes sense. I usually prefer to keep the filters in one place but this is simpler and cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #480: [TC-236] status page only shows ...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/480#discussion_r112078813
--- Diff: traffic_ops/app/lib/UI/Server.pm ---
@@ -912,12 +912,12 @@ sub readupdate {
my $rs_parents = $self->db->resultset('Server')->search( { cachegroup => $parent_cg }, { prefetch => [ 'status'] } );
--- End diff --
couldn't you just put the check for the CDN here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---