You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/22 12:55:42 UTC
[GitHub] [incubator-kyuubi] yikf opened a new pull request, #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
yikf opened a new pull request, #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix https://github.com/apache/incubator-kyuubi/issues/3306
Currently, Kyuubi-AuthZ support Apache Spark 3.0 and above, and there are no CI workflow to check compatibility with Apache Spark 3.0, this pr aim to add a CI workflow for AuthZ module
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1223784549
we can separate it to a new yml, and fully test all supported versions in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952102593
##########
.github/workflows/master.yml:
##########
@@ -97,6 +97,47 @@ jobs:
**/target/unit-tests.log
**/kyuubi-spark-sql-engine.log*
+ authz:
+ name: Kyuubi-AuthZ and Spark Test
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ java:
+ - 8
+ - 11
+ spark:
+ - '3.0'
Review Comment:
3.0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r951408369
##########
.github/workflows/master.yml:
##########
@@ -97,6 +97,53 @@ jobs:
**/target/unit-tests.log
**/kyuubi-spark-sql-engine.log*
+ authz:
+ name: Kyuubi-AuthZ and Spark Test
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ java:
+ - 8
+ - 11
+ spark:
+ - '3.0'
+ spark-archive: [""]
+ exclude-tags: [""]
+ comment: ["normal"]
+ include:
+ - java: 8
+ spark: '3.0'
+ spark-archive: '-Dspark.archive.mirror=https://archive.apache.org/dist/spark/spark-3.0.0 -Dspark.archive.name=spark-3.0.0-bin-hadoop3.2.tgz'
+ exclude-tags: '-Dmaven.plugin.scalatest.exclude.tags=org.scalatest.tags.Slow'
+ comment: 'verify-on-spark-3.0-binary'
Review Comment:
remove this block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1222427755
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3307](https://codecov.io/gh/apache/incubator-kyuubi/pull/3307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25ab695) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bc168527177899e2a72c50cb8f4477c15b4f9452?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc16852) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3307 +/- ##
============================================
- Coverage 51.45% 51.44% -0.02%
Complexity 13 13
============================================
Files 470 470
Lines 26242 26242
Branches 3629 3629
============================================
- Hits 13504 13501 -3
- Misses 11462 11463 +1
- Partials 1276 1278 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/engine/JpsApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvSnBzQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `77.41% <0.00%> (-3.23%)` | :arrow_down: |
| [...pache/kyuubi/engine/YarnApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvWWFybkFwcGxpY2F0aW9uT3BlcmF0aW9uLnNjYWxh) | `64.81% <0.00%> (-1.86%)` | :arrow_down: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `91.17% <0.00%> (-0.30%)` | :arrow_down: |
| [...che/kyuubi/server/KyuubiTHttpFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpVEh0dHBGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `64.96% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yikf commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yikf commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1223870487
> can we add a maven profile for authz module to enable it when needed?
beacuse spark 3.0 support is EOL, we aims to use -Dspark.version instead of prifile, https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952089562,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1225089340
Sorry, I don't mean a profile for spark.version, but a profile for authz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952102752
##########
.github/workflows/master.yml:
##########
@@ -97,6 +97,47 @@ jobs:
**/target/unit-tests.log
**/kyuubi-spark-sql-engine.log*
+ authz:
+ name: Kyuubi-AuthZ and Spark Test
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ java:
+ - 8
+ - 11
+ spark:
+ - '3.0'
+ spark-archive: [""]
+ exclude-tags: [""]
+ comment: ["normal"]
+ env:
+ SPARK_LOCAL_IP: localhost
+ steps:
+ - uses: actions/checkout@v2
+ - name: Tune Runner VM
+ uses: ./.github/actions/tune-runner-vm
+ - name: Setup JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ distribution: zulu
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+ check-latest: false
+ - name: Build and test Kyuubi AuthZ with supported Spark versions
+ run: |
+ TEST_MODULES="extensions/spark/kyuubi-spark-authz"
+ ./build/mvn clean test ${MVN_OPT} -pl ${TEST_MODULES} -am \
+ -Dspark.version=3.0.0
Review Comment:
-Dspark.version=${{ matrix.spark }}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952095876
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -288,4 +288,14 @@
</testResources>
</build>
+ <profiles>
+ <profile>
+ <id>spark-3.0</id>
Review Comment:
sgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yikf commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yikf commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1223536303
CI passed, thanks all @pan3793 @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1223844403
can we add a maven profile for authz module to enable it when needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952177023
##########
.github/workflows/master.yml:
##########
@@ -97,6 +97,47 @@ jobs:
**/target/unit-tests.log
**/kyuubi-spark-sql-engine.log*
+ authz:
+ name: Kyuubi-AuthZ and Spark Test
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ java:
+ - 8
+ - 11
+ spark:
+ - '3.0.3'
+ spark-archive: [""]
+ exclude-tags: [""]
Review Comment:
nit:
```diff
- spark-archive: [""]
- exclude-tags: [""]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1225233448
it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
URL: https://github.com/apache/incubator-kyuubi/pull/3307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Yikf commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
Yikf commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1225120065
> Sorry, I don't mean a profile for spark.version, but a profile for authz
emm, sorry ~ do you mean a profile in authz's pom.xml? like https://github.com/apache/incubator-kyuubi/commit/25ab69559254ce59905bf4bcf0494c2b4aa23adb#diff-9a465978616fd38123253294b36f679de4cbd32e577d3dfd981a7db49117b9e5R291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952089562
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -288,4 +288,14 @@
</testResources>
</build>
+ <profiles>
+ <profile>
+ <id>spark-3.0</id>
Review Comment:
spark 3.0 support is EOL after #2974 . Maybe we can use a command line argument to specify the Spark version. WDYT? cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yikf commented on pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yikf commented on PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#issuecomment-1223815426
> we can separate it to a new yml, and fully test all supported versions in it
separate it to a new yml sgtm, all supported version is 3.0.3、3.1.3、3.2.2、3.3.0, but versions 3.1.3、3.2.2、3.3.0 have been checked by `Kyuubi and Spark Test`, and 2.4 not supported after https://github.com/apache/incubator-kyuubi/pull/3305, it looks like we only check 3.0.3 for authZ?
Or, independently of `Kyuubi and Spark Test`(not depend on it), the new yml is authZ only and checks all versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952089562
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -288,4 +288,14 @@
</testResources>
</build>
+ <profiles>
+ <profile>
+ <id>spark-3.0</id>
Review Comment:
spark 3.0 is EOL after #2974 . Maybe we can use a command line argument to specify the Spark version. WDYT? cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yikf commented on a diff in pull request #3307: [KYUUBI #3306][INFRA] Add CI workflow for Kyuubi-AuthZ
Posted by GitBox <gi...@apache.org>.
yikf commented on code in PR #3307:
URL: https://github.com/apache/incubator-kyuubi/pull/3307#discussion_r952190348
##########
.github/workflows/master.yml:
##########
@@ -97,6 +97,47 @@ jobs:
**/target/unit-tests.log
**/kyuubi-spark-sql-engine.log*
+ authz:
+ name: Kyuubi-AuthZ and Spark Test
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ java:
+ - 8
+ - 11
+ spark:
+ - '3.0.3'
+ spark-archive: [""]
+ exclude-tags: [""]
Review Comment:
thanks, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org