[jira] Commented: (CAMEL-3737) ResequenceDefinition in XML allows 2 configurations to be specified, and which is not ideal.

["james strachan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000872#comment-13000872 ] 

james strachan commented on CAMEL-3737:
---------------------------------------

Looks like the LoadBalancerDefinition needs to be the same kind of thing so it can be properly configured in XML

> ResequenceDefinition in XML allows 2 configurations to be specified, <batchConfig> and <streamConfig> which is not ideal.
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-3737
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3737
>             Project: Camel
>          Issue Type: Task
>            Reporter: james strachan
>
> Right now its possible in XML to specify both kinds of configuration; batchConfig and streamConfig. This isn't ideal and the definition is a bit floored.
> {code}
>    // Binding annotation at setter
>     private BatchResequencerConfig batchConfig;
>     // Binding annotation at setter
>     private StreamResequencerConfig streamConfig;
> {code}
> It should probably use the same JAXB stuff as MarshalDefinition so that it can take one element of a list of possible value types:
> {code}
> public class MarshalDefinition extends OutputDefinition<MarshalDefinition> {
>     // cannot use @XmlElementRef as it doesn't allow optional properties
>     @XmlElements({
>     @XmlElement(required = false, name = "bindy", type = BindyDataFormat.class),
>     @XmlElement(required = false, name = "castor", type = CastorDataFormat.class),
>     @XmlElement(required = false, name = "csv", type = CsvDataFormat.class),
>     @XmlElement(required = false, name = "crypto", type = CryptoDataFormat.class),
>     @XmlElement(required = false, name = "flatpack", type = FlatpackDataFormat.class),
>     @XmlElement(required = false, name = "gzip", type = GzipDataFormat.class),
>     @XmlElement(required = false, name = "hl7", type = HL7DataFormat.class),
>     @XmlElement(required = false, name = "jaxb", type = JaxbDataFormat.class),
>     @XmlElement(required = false, name = "jibx", type = JibxDataFormat.class),
>     @XmlElement(required = false, name = "json", type = JsonDataFormat.class),
>     @XmlElement(required = false, name = "rss", type = RssDataFormat.class),
>     @XmlElement(required = false, name = "secureXML", type = XMLSecurityDataFormat.class),
>     @XmlElement(required = false, name = "serialization", type = SerializationDataFormat.class),
>     @XmlElement(required = false, name = "string", type = StringDataFormat.class),
>     @XmlElement(required = false, name = "syslog", type = SyslogDataFormat.class),
>     @XmlElement(required = false, name = "xmlBeans", type = XMLBeansDataFormat.class),
>     @XmlElement(required = false, name = "xstream", type = XStreamDataFormat.class),
>     @XmlElement(required = false, name = "zip", type = ZipDataFormat.class)}
>     )
>     private DataFormatDefinition dataFormatType;
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira