You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/06/28 23:10:10 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #10997: Fix a flaky test NullEnabledQueriesTest.testQueriesWithDictFloatColumnNoNullValues.
shenyu0127 opened a new pull request, #10997:
URL: https://github.com/apache/pinot/pull/10997
The test is flaky because we store the column as float and do a `SELECT WHERE column = Float.doubleValue()` query.
We can reproduce a failed test by changing line 224 to `Float baseValue = 0.05102920532226562568f`.
Tested:
- Changing line 224 to `Float baseValue = 0.05102920532226562568f` and running the test.
- Running the rest with `invocationCount = 200`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10997: Fix a flaky test NullEnabledQueriesTest.testQueriesWithDictFloatColumnNoNullValues.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10997:
URL: https://github.com/apache/pinot/pull/10997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10997: Fix a flaky test NullEnabledQueriesTest.testQueriesWithDictFloatColumnNoNullValues.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10997:
URL: https://github.com/apache/pinot/pull/10997#issuecomment-1612246794
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10997](https://app.codecov.io/gh/apache/pinot/pull/10997?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9b90159) into [master](https://app.codecov.io/gh/apache/pinot/commit/82252ed84340627223258ba1aaeb1b372a86c2f9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (82252ed) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10997 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2191 2137 -54
Lines 118037 115532 -2505
Branches 17883 17581 -302
=========================================
Hits 137 137
+ Misses 117880 115375 -2505
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `0.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 56 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10997/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org