You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/09 08:52:09 UTC

[GitHub] [flink] wenbingshen opened a new pull request, #20798: [FLINK-29207][connector/pulsar] release-1.16 Fix Pulsar message eventTime may be incorrectly set to a negative number

wenbingshen opened a new pull request, #20798:
URL: https://github.com/apache/flink/pull/20798

   ## What is the purpose of the change
   We'd better judge that the `timestamp` is greater than 0, we should skip setting eventTime when timestamp less than or equal to 0, otherwise the pulsar client will throw an exception.
   
   ## Brief change log
   check the `timestamp` is greater than 0
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] wenbingshen commented on pull request #20798: [FLINK-29207][connector/pulsar] release-1.16 Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #20798:
URL: https://github.com/apache/flink/pull/20798#issuecomment-1241701565

   ping @tisonkun PTAL, Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #20798: [FLINK-29207][connector/pulsar] release-1.16 Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20798:
URL: https://github.com/apache/flink/pull/20798#issuecomment-1241701176

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f36bf0f8baf1afd5f409f2b989340650fab0b3b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0f36bf0f8baf1afd5f409f2b989340650fab0b3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f36bf0f8baf1afd5f409f2b989340650fab0b3b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] tisonkun merged pull request #20798: [FLINK-29207][connector/pulsar] release-1.16 Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #20798:
URL: https://github.com/apache/flink/pull/20798


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org