You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/11/18 00:26:05 UTC
Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28137/
-----------------------------------------------------------
(Updated Nov. 17, 2014, 11:26 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
pull line out of summary into description.
Summary (updated)
-----------------
Fix ProcTest.MultipleThreads hanging.
Bugs: MESOS-2121
https://issues.apache.org/jira/browse/MESOS-2121
Repository: mesos-git
Description (updated)
-------
Replace sleep with pthread_testcancel.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e
Diff: https://reviews.apache.org/r/28137/diff/
Testing
-------
make check
3rdparty/stout-tests --gtest_repeat=500
Thanks,
Joris Van Remoortere
Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28137/#review62427
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Nov. 19, 2014, 9:41 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28137/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 9:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2121
> https://issues.apache.org/jira/browse/MESOS-2121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace sleep with pthread_testcancel.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e
>
> Diff: https://reviews.apache.org/r/28137/diff/
>
>
> Testing
> -------
>
> make check
> 3rdparty/stout-tests --gtest_repeat=500
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28137/#review62272
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28137]
All tests passed.
- Mesos ReviewBot
On Nov. 19, 2014, 9:41 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28137/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 9:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2121
> https://issues.apache.org/jira/browse/MESOS-2121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace sleep with pthread_testcancel.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e
>
> Diff: https://reviews.apache.org/r/28137/diff/
>
>
> Testing
> -------
>
> make check
> 3rdparty/stout-tests --gtest_repeat=500
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28137/
-----------------------------------------------------------
(Updated Nov. 19, 2014, 9:41 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Update comments.
Rename function.
Bugs: MESOS-2121
https://issues.apache.org/jira/browse/MESOS-2121
Repository: mesos-git
Description
-------
Replace sleep with pthread_testcancel.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e
Diff: https://reviews.apache.org/r/28137/diff/
Testing
-------
make check
3rdparty/stout-tests --gtest_repeat=500
Thanks,
Joris Van Remoortere
Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28137/#review61839
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28137]
All tests passed.
- Mesos ReviewBot
On Nov. 17, 2014, 11:26 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28137/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 11:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2121
> https://issues.apache.org/jira/browse/MESOS-2121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace sleep with pthread_testcancel.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e
>
> Diff: https://reviews.apache.org/r/28137/diff/
>
>
> Testing
> -------
>
> make check
> 3rdparty/stout-tests --gtest_repeat=500
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28137/#review62200
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
<https://reviews.apache.org/r/28137/#comment104210>
Let's add a comment that explains that we needed to add pthread_test_cancel() because we've seen this hang on certain machines even though sleep() should be cancelable.
- Benjamin Hindman
On Nov. 17, 2014, 11:26 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28137/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 11:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2121
> https://issues.apache.org/jira/browse/MESOS-2121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace sleep with pthread_testcancel.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e
>
> Diff: https://reviews.apache.org/r/28137/diff/
>
>
> Testing
> -------
>
> make check
> 3rdparty/stout-tests --gtest_repeat=500
>
>
> Thanks,
>
> Joris Van Remoortere
>
>