You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/28 03:30:55 UTC

[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #11187: [Improvement][Registry] Add support for Zookeeper ACL

EricGao888 opened a new issue, #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   * Zookeeper has `Access Control List` feature for security purpose, protecting the security of data in `znodes`.
   * We could add support for `DS` users to register ZK which enables ACL.
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] EricGao888 commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1198047988

   > I've tested it. DS has already supported connecting to ZK with ACL enabled. All we need is to add corresponding `digest` configurations in `application.yaml`. However, we do not have related docs and we need to add docs for this.
   
   We need to add docs to instruct users on how to config ZK `namespace`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] EricGao888 commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1198050032

   > interested in this issue
   
   Sure, thx for help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1197629167

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] abzymeinsjtu commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
abzymeinsjtu commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1198049625

   interested in this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] beeflyme commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
beeflyme commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1199031751

   **add some comment for using zookeeper with kerberos or not:**
   
   **refer to:**
       https://issues.apache.org/jira/browse/ZOOKEEPER-2139
       Support multiple ZooKeeper client, with different configurations, in a single JVM
   **the zk problem detail:**
       I have two ZK client in one JVM, one is secure client and second is normal client (For non secure cluster).
   **zk solution:**:add a new var ClientConfiguration to pass different zk cluster vars.
      
       public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher,
               boolean canBeReadOnly, ClientConfiguration conf) throws IOException {   
   
   now dolphine problem:
      1. dolphine master itself use zk to store some dolphin data
      2. when add data source , conn to componts such as hive/presto/...  , dolphine will conn to the zk of the cluster first.
      
   then zk client(master of the dolphine ) hard to conn different type of cluster (with kerberos or not)
     
   
   one way to slove: dolphine conn zk use the new zk api ,with var of "ClientConfiguration conf"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1229597212

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] EricGao888 closed issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
EricGao888 closed issue #11187: [Improvement][Registry] Add support for Zookeeper ACL
URL: https://github.com/apache/dolphinscheduler/issues/11187


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] EricGao888 commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1198046261

   I've tested it. DS has already supported connecting to ZK with ACL enabled. All we need is to add corresponding `digest` configurations in `application.yaml`. However, we do not have related docs and we need to add docs for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] EricGao888 commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1199043375

   > **add some comment for using zookeeper with kerberos or not:**
   > 
   > **refer to:** https://issues.apache.org/jira/browse/ZOOKEEPER-2139 Support multiple ZooKeeper client, with different configurations, in a single JVM **the zk problem detail:** I have two ZK client in one JVM, one is secure client and second is normal client (For non secure cluster). **zk solution:**:add a new var ClientConfiguration to pass different zk cluster vars.
   > 
   > ```
   > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher,
   >         boolean canBeReadOnly, ClientConfiguration conf) throws IOException {   
   > ```
   > 
   > now dolphine problem:
   > 
   > 1. dolphine master itself use zk to store some dolphin data
   > 2. when add data source , conn to componts such as hive/presto/...  , dolphine will conn to the zk of the cluster first.
   > 
   > then zk client(master of the dolphine ) hard to conn different type of cluster (with kerberos or not)
   > 
   > one way to slove: dolphine conn zk use the new zk api ,with var of "ClientConfiguration conf"
   
   Hi @beeflyme , thx for the comment. However, this looks a little bit out of the scope of this issue. Would u plz open a new issue for it? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] EricGao888 commented on issue #11187: [Improvement][Registry] Add support for Zookeeper ACL

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11187:
URL: https://github.com/apache/dolphinscheduler/issues/11187#issuecomment-1229797465

   > This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
   
   WIP, no stale


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org