[jira] [Commented] (SLING-3501) Unexpected behaviour when using multiple tags in the web console to run checks

["Georg Henzler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228705#comment-14228705 ] 

Georg Henzler commented on SLING-3501:
--------------------------------------

[~bdelacretaz] I think I found a good solution by introducing a class HealthCheckExecutionOptions that can be optionally passed to the executor. Find attached a patch that introduces the or option in these options and in the web console. Additionally the options contain two values (forceInstantExcecution and overrideGlobalTimeout) that can also be set in the web console (this was easy to add, now that there are the execution options). All changes are completely backward compatible. 

> Unexpected behaviour when using multiple tags in the web console to run checks
> ------------------------------------------------------------------------------
>
>                 Key: SLING-3501
>                 URL: https://issues.apache.org/jira/browse/SLING-3501
>             Project: Sling
>          Issue Type: Bug
>          Components: Health Check
>            Reporter: Georg Henzler
>            Assignee: Bertrand Delacretaz
>         Attachments: SLING-3501-executor-options.patch, SLING-3501-filter-for-taglist-fix.patch
>
>
> Multiple tags (e.g. "category1,category2") are connected with a logical AND at the moment, that means for the given example only HCs with both category tags would be run. 
> From a user's point of view this behaviour is not intuitive (IMHO, also see Björn's comment in the sling-users list [1]). Using the tags "category1,category2" should rather cause all checks of both categories to be run (union instead of intersection). 
> The problem is evident for both the web console [2] and when configuring CompositeHealthChecks (both use HealthCheckFilter).
> [1] http://apache-sling.73963.n3.nabble.com/Healthcheck-Unexpected-behavior-with-tags-td4032090.html
> [2] http://localhost:4502/system/console/healthcheck



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)