You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/05 01:44:22 UTC
[GitHub] [spark] allisonwang-db opened a new pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
allisonwang-db opened a new pull request #31749:
URL: https://github.com/apache/spark/pull/31749
### What changes were proposed in this pull request?
This PR updates UnresolvedTableValuedFunction's name to be a FunctionIdentifier instead of a string.
### Why are the changes needed?
To make UnresolvedTableValuedFunction consistent with UnresolvedFunction that uses FunctionIdentifier as the function name.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing SQL query tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793224033
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40469/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31749:
URL: https://github.com/apache/spark/pull/31749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793191728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793231830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40469/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793206590
**[Test build #135886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135886/testReport)** for PR 31749 at commit [`d12e984`](https://github.com/apache/spark/commit/d12e9847915d1ed26eb0324eb65fd875f3f9910e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793231830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40469/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791201666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135785/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793427797
**[Test build #135886 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135886/testReport)** for PR 31749 at commit [`d12e984`](https://github.com/apache/spark/commit/d12e9847915d1ed26eb0324eb65fd875f3f9910e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793445250
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135886/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791118549
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31749:
URL: https://github.com/apache/spark/pull/31749#discussion_r589257679
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1144,7 +1144,9 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
val tvf = UnresolvedTableValuedFunction(
- func.funcName.getText, func.expression.asScala.map(expression).toSeq, aliases)
+ getFunctionIdentifier(func.functionName),
Review comment:
shall we make sure the `database` part is None to be consistent with before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791201666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135785/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791134378
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793206590
**[Test build #135886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135886/testReport)** for PR 31749 at commit [`d12e984`](https://github.com/apache/spark/commit/d12e9847915d1ed26eb0324eb65fd875f3f9910e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791134378
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791190681
**[Test build #135785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135785/testReport)** for PR 31749 at commit [`72fed75`](https://github.com/apache/spark/commit/72fed7500130fbe88b08d73a964df2b39da404ee).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793217083
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40469/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791603126
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793420963
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791130708
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791088228
**[Test build #135785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135785/testReport)** for PR 31749 at commit [`72fed75`](https://github.com/apache/spark/commit/72fed7500130fbe88b08d73a964df2b39da404ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793191731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-791088228
**[Test build #135785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135785/testReport)** for PR 31749 at commit [`72fed75`](https://github.com/apache/spark/commit/72fed7500130fbe88b08d73a964df2b39da404ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31749:
URL: https://github.com/apache/spark/pull/31749#issuecomment-793445250
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135886/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org