You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2024/10/22 18:23:20 UTC

(kafka) branch trunk updated: MINOR: Fix duplicate condition in ReadOnlyWindowStoreStub (#17540)

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1c405875fa8 MINOR: Fix duplicate condition in ReadOnlyWindowStoreStub (#17540)
1c405875fa8 is described below

commit 1c405875fa88ef4b7d93c1ae38fe5020c5506561
Author: Dmitry Werner <gr...@gmail.com>
AuthorDate: Tue Oct 22 23:23:14 2024 +0500

    MINOR: Fix duplicate condition in ReadOnlyWindowStoreStub (#17540)
    
    Reviewers: Ken Huang <s7...@gmail.com>, Chia-Ping Tsai <ch...@gmail.com>
---
 .../apache/kafka/streams/state/internals/ReadOnlyWindowStoreStub.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/ReadOnlyWindowStoreStub.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/ReadOnlyWindowStoreStub.java
index 9a211c02188..67f27f4a1dd 100644
--- a/streams/src/test/java/org/apache/kafka/streams/state/internals/ReadOnlyWindowStoreStub.java
+++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/ReadOnlyWindowStoreStub.java
@@ -268,7 +268,7 @@ public class ReadOnlyWindowStoreStub<K, V> implements ReadOnlyWindowStore<K, V>,
             final NavigableMap<K, V> kvMap = data.get(now);
             if (kvMap != null) {
                 final NavigableMap<K, V> kvSubMap;
-                if (keyFrom == null && keyFrom == null) {
+                if (keyFrom == null && keyTo == null) {
                     kvSubMap = kvMap;
                 } else if (keyFrom == null) {
                     kvSubMap = kvMap.headMap(keyTo, true);
@@ -324,7 +324,7 @@ public class ReadOnlyWindowStoreStub<K, V> implements ReadOnlyWindowStore<K, V>,
             final NavigableMap<K, V> kvMap = data.get(now);
             if (kvMap != null) {
                 final NavigableMap<K, V> kvSubMap;
-                if (keyFrom == null && keyFrom == null) {
+                if (keyFrom == null && keyTo == null) {
                     kvSubMap = kvMap;
                 } else if (keyFrom == null) {
                     kvSubMap = kvMap.headMap(keyTo, true);