You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "clebertsuconic (via GitHub)" <gi...@apache.org> on 2026/09/21 14:32:55 UTC

[PR] NO-JIRA Code cleanup: Use Supplier for Transaction.getProperty/addOperation pairs [artemis]

clebertsuconic opened a new pull request, #6730:
URL: https://github.com/apache/artemis/pull/6730

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] NO-JIRA Code cleanup: Use Supplier for Transaction.getProperty/addOperation pairs [artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6730:
URL: https://github.com/apache/artemis/pull/6730#issuecomment-5767266451

   This looks good to me. My only question is why not push a real default implementation into the interface rather than having a no-op (i.e. `return null`)? Everything in `TransactionImpl` can actually go into `Transaction`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] NO-JIRA Code cleanup: Use Supplier for Transaction.getProperty/addOperation pairs [artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6730:
URL: https://github.com/apache/artemis/pull/6730#issuecomment-5769245459

   > however you won't have the setProperty / getProperty...
   
   I don't understand. Both `getProperty` and `putProperty` are part of the interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] NO-JIRA Code cleanup: Use Supplier for Transaction.getProperty/addOperation pairs [artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic merged PR #6730:
URL: https://github.com/apache/artemis/pull/6730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] NO-JIRA Code cleanup: Use Supplier for Transaction.getProperty/addOperation pairs [artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #6730:
URL: https://github.com/apache/artemis/pull/6730#issuecomment-5767501879

   Claude originally wrote this on the default implementation (I actually need to say co-authored with Claude onthe commit). however you won't have the setProperty / getProperty. so I decided to move it down.
   
   I will update the commit message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] NO-JIRA Code cleanup: Use Supplier for Transaction.getProperty/addOperation pairs [artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6730:
URL: https://github.com/apache/artemis/pull/6730#issuecomment-5767293860

   One nit-pick...take "Code cleanup:" out of the commit message so that it's just:
   ```
   NO-JIRA use Supplier for Transaction.getProperty/addOperation pairs
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org