You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2014/10/06 21:47:45 UTC

Review Request 26378: Upgrade to pants 0.0.24

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.


Bugs: AURORA-363
    https://issues.apache.org/jira/browse/AURORA-363


Repository: aurora


Description
-------

Upgrade to pants 0.0.24


Diffs
-----

  pants 61468a9ea51f3abe7db48f605f8623321005c3a8 
  pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 

Diff: https://reviews.apache.org/r/26378/diff/


Testing
-------

[tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh 


Thanks,

Joe Smith


Re: Review Request 26378: Upgrade to pants 0.0.24

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378/#review55613
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Wickman


On Oct. 6, 2014, 7:53 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26378/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 7:53 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-363
>     https://issues.apache.org/jira/browse/AURORA-363
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to pants 0.0.24
> 
> The biggest highlight from the changelog at https://pypi.python.org/pypi/pantsbuild.pants/0.0.24 is this will enforce python2.7 across the repository.
> 
> 
> Diffs
> -----
> 
>   pants 61468a9ea51f3abe7db48f605f8623321005c3a8 
>   pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 
> 
> Diff: https://reviews.apache.org/r/26378/diff/
> 
> 
> Testing
> -------
> 
> [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Re: Review Request 26378: Upgrade to pants 0.0.24

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378/#review55595
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Oct. 6, 2014, 7:53 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26378/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 7:53 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-363
>     https://issues.apache.org/jira/browse/AURORA-363
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to pants 0.0.24
> 
> The biggest highlight from the changelog at https://pypi.python.org/pypi/pantsbuild.pants/0.0.24 is this will enforce python2.7 across the repository.
> 
> 
> Diffs
> -----
> 
>   pants 61468a9ea51f3abe7db48f605f8623321005c3a8 
>   pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 
> 
> Diff: https://reviews.apache.org/r/26378/diff/
> 
> 
> Testing
> -------
> 
> [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Re: Review Request 26378: Upgrade to pants 0.0.24

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378/
-----------------------------------------------------------

(Updated Oct. 6, 2014, 12:53 p.m.)


Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.


Changes
-------

Added changelog (thanks for the nudge, Zameer!)


Bugs: AURORA-363
    https://issues.apache.org/jira/browse/AURORA-363


Repository: aurora


Description (updated)
-------

Upgrade to pants 0.0.24

The biggest highlight from the changelog at https://pypi.python.org/pypi/pantsbuild.pants/0.0.24 is this will enforce python2.7 across the repository.


Diffs
-----

  pants 61468a9ea51f3abe7db48f605f8623321005c3a8 
  pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 

Diff: https://reviews.apache.org/r/26378/diff/


Testing
-------

[tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh 


Thanks,

Joe Smith


Re: Review Request 26378: Upgrade to pants 0.0.24

Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378/#review55566
-----------------------------------------------------------

Ship it!


The big win we are getting from this is the repo wide interpreter enforcement.

- Zameer Manji


On Oct. 6, 2014, 12:47 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26378/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 12:47 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-363
>     https://issues.apache.org/jira/browse/AURORA-363
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to pants 0.0.24
> 
> 
> Diffs
> -----
> 
>   pants 61468a9ea51f3abe7db48f605f8623321005c3a8 
>   pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 
> 
> Diff: https://reviews.apache.org/r/26378/diff/
> 
> 
> Testing
> -------
> 
> [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Joe Smith
> 
>