You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (via GitHub)" <gi...@apache.org> on 2023/12/21 07:07:21 UTC

[I] `dubboctl` to support some Dubbo oriented operations for Zookeeper [dubbo-kubernetes]

chickenlj opened a new issue, #122:
URL: https://github.com/apache/dubbo-kubernetes/issues/122

   Here're some reference implementations that might ease the work of connecting to Zookeeper server: 
   * https://github.com/go-zkcli/zkcli


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] `dubboctl` to support some Dubbo oriented operations for Zookeeper [dubbo-kubernetes]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj closed issue #122: `dubboctl` to support some Dubbo oriented operations for Zookeeper
URL: https://github.com/apache/dubbo-kubernetes/issues/122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] `dubboctl` to support some Dubbo oriented operations for Zookeeper [dubbo-kubernetes]

Posted by "sjcsjc123 (via GitHub)" <gi...@apache.org>.
sjcsjc123 commented on issue #122:
URL: https://github.com/apache/dubbo-kubernetes/issues/122#issuecomment-1868507914

   初步接口如下,是否有需要修改的或者补充的
   ```go
   // Registry 是注册中心的接口
   type Registry interface {
   	// ListServices 列出所有服务名
   	ListServices(ctx *context.Context) ([]string, error)
   	// ListInstances 列出指定服务名的所有实例
   	ListInstances(ctx *context.Context, serviceName string) ([]string, error)
   	// GetRouteRule 获取指定服务名已生效的路由规则
   	GetRouteRule(ctx *context.Context, serviceName string) (Rule, error)
   	// SetRouteRule 设置指定服务名的路由规则
   	SetRouteRule(ctx *context.Context, serviceName string, rule Rule) error
   	// RegisterService 注册服务
   	RegisterService(ctx *context.Context, service Service) error
   	// UnregisterService 注销服务
   	UnregisterService(ctx *context.Context, service Service) error
   	// GetServiceByRule 根据路由规则获取服务
   	GetServiceByRule(ctx *context.Context, serviceName string, rule Rule) (Service, error)
   }
   
   type Rule interface {
   	// GetConfigVersion 获取配置版本号
   	GetConfigVersion(ctx *context.Context) string
   	// GetRuleType 获取路由规则类型
   	GetRuleType(ctx *context.Context) string
   	// GetRouteRule 获取路由规则
   	GetRouteRule(ctx *context.Context) string
   	// SetRouteRule 设置路由规则,有条件路由\标签路由\脚本路由\动态配置路由
   	SetRouteRule(ctx *context.Context, rule interface{}) error
   }
   
   type Service struct {
   	Ip   string
   	Port int
   	// 更多字段
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] `dubboctl` to support some Dubbo oriented operations for Zookeeper [dubbo-kubernetes]

Posted by "sjcsjc123 (via GitHub)" <gi...@apache.org>.
sjcsjc123 commented on issue #122:
URL: https://github.com/apache/dubbo-kubernetes/issues/122#issuecomment-1865744714

   1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] `dubboctl` to support some Dubbo oriented operations for Zookeeper [dubbo-kubernetes]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on issue #122:
URL: https://github.com/apache/dubbo-kubernetes/issues/122#issuecomment-1869302010

   > // RegisterService 注册服务
   > RegisterService(ctx *context.Context, service Service) error
   > // UnregisterService 注销服务
   > UnregisterService(ctx *context.Context, service Service) error
   > // GetServiceByRule 根据路由规则获取服务
   > GetServiceByRule(ctx *context.Context, serviceName string, rule Rule) (Service, error)
   
   These three methods can be removed.
   
   > ```
   > type Rule interface {
   > 	// GetConfigVersion 获取配置版本号
   > 	GetConfigVersion(ctx *context.Context) string
   > 	// GetRuleType 获取路由规则类型
   > 	GetRuleType(ctx *context.Context) string
   > 	// GetRouteRule 获取路由规则
   > 	GetRouteRule(ctx *context.Context) string
   > 	// SetRouteRule 设置路由规则,有条件路由\标签路由\脚本路由\动态配置路由
   > 	SetRouteRule(ctx *context.Context, rule interface{}) error
   > }
   > ```
   
   Rule-related methods should also has parameters like `serviceName` and `ruleType`: `GetRuleType(ctx *context.Context, serviceName string, ruleType RuleType) string`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org