You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/19 07:02:01 UTC
[GitHub] [incubator-shardingsphere] geomonlin opened a new pull request
#4840: Parameter marker#4776
geomonlin opened a new pull request #4840: Parameter marker#4776
URL: https://github.com/apache/incubator-shardingsphere/pull/4840
Fixes #4776 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4840:
Parameter marker#4776
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4840: Parameter marker#4776
URL: https://github.com/apache/incubator-shardingsphere/pull/4840#issuecomment-601036201
@geomonlin Hi Merged, clear and hard-work. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4840:
Parameter marker#4776
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4840: Parameter marker#4776
URL: https://github.com/apache/incubator-shardingsphere/pull/4840#issuecomment-601032254
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840?src=pr&el=h1) Report
> Merging [#4840](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/93123ece4f2d493ee23b1458d75554108d55164c&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4840 +/- ##
============================================
- Coverage 56.28% 56.25% -0.03%
Complexity 449 449
============================================
Files 1166 1166
Lines 20940 20950 +10
Branches 3883 3885 +2
============================================
Hits 11786 11786
- Misses 8428 8438 +10
Partials 726 726
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840?src=pr&el=footer). Last update [93123ec...d3d85f2](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4840:
Parameter marker#4776
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4840: Parameter marker#4776
URL: https://github.com/apache/incubator-shardingsphere/pull/4840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4840:
Parameter marker#4776
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4840: Parameter marker#4776
URL: https://github.com/apache/incubator-shardingsphere/pull/4840#issuecomment-601034213
## Pull Request Test Coverage Report for [Build 10392](https://coveralls.io/builds/29464745)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **18** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.08%**) to **59.78%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29464745/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29464745/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29464745/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
<!-- | **Total:** | **18** | | -->
| Totals | [](https://coveralls.io/builds/29464745) |
| :-- | --: |
| Change from base [Build 1115](https://coveralls.io/builds/29463282): | -0.08% |
| Covered Lines: | 12524 |
| Relevant Lines: | 20950 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services