You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/04 09:41:44 UTC
[GitHub] [incubator-seatunnel] lvshaokang opened a new pull request, #3863: [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
lvshaokang opened a new pull request, #3863:
URL: https://github.com/apache/incubator-seatunnel/pull/3863
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
refer #3815
Fix text and json write strategy lost the sinkColumnsIndexInRow
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3863: [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #3863:
URL: https://github.com/apache/incubator-seatunnel/pull/3863#discussion_r1062085746
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -95,6 +96,12 @@ public SeaTunnelRow copy(int[] indexMapping) {
return newRow;
}
+ public SeaTunnelRow copy(List<Integer> indexMapping) {
+ return copy(indexMapping.stream()
+ .mapToInt(Integer::intValue)
+ .toArray());
+ }
+
Review Comment:
Aggre with @hailin0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lvshaokang commented on a diff in pull request #3863: [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
Posted by GitBox <gi...@apache.org>.
lvshaokang commented on code in PR #3863:
URL: https://github.com/apache/incubator-seatunnel/pull/3863#discussion_r1062118474
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -95,6 +96,12 @@ public SeaTunnelRow copy(int[] indexMapping) {
return newRow;
}
+ public SeaTunnelRow copy(List<Integer> indexMapping) {
+ return copy(indexMapping.stream()
+ .mapToInt(Integer::intValue)
+ .toArray());
+ }
+
Review Comment:
@hailin0 @TyrantLucifer done. thanks for you review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #3863: [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #3863:
URL: https://github.com/apache/incubator-seatunnel/pull/3863#issuecomment-1371743446
@TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #3863: [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #3863:
URL: https://github.com/apache/incubator-seatunnel/pull/3863#issuecomment-1385660479
@TyrantLucifer PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3863: [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #3863:
URL: https://github.com/apache/incubator-seatunnel/pull/3863#discussion_r1062080943
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -95,6 +96,12 @@ public SeaTunnelRow copy(int[] indexMapping) {
return newRow;
}
+ public SeaTunnelRow copy(List<Integer> indexMapping) {
+ return copy(indexMapping.stream()
+ .mapToInt(Integer::intValue)
+ .toArray());
+ }
+
Review Comment:
remove this method, move to caller location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #3863: [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #3863:
URL: https://github.com/apache/incubator-seatunnel/pull/3863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org