[GitHub] [tinkerpop] alexey-temnikov commented on a diff in pull request #1883: TINKERPOP-2480 Add User-Agent to Javascript Driver

[GitBox <gi...@apache.org>]

alexey-temnikov commented on code in PR #1883:
URL: https://github.com/apache/tinkerpop/pull/1883#discussion_r1042551583


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js:
##########
@@ -24,6 +24,8 @@
 'use strict';
 
 const crypto = require('crypto');
+const os = require('os');
+const gremlinVersion = require(__dirname + '/../package.json').version;

Review Comment:
   Let's confirm this still works even when the target client application is compiled in minimized js package (so reference to JSON file is not lost).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org