You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/10/31 14:49:27 UTC

[GitHub] [kafka] C0urante commented on pull request #12784: KAFKA-14339 : Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

C0urante commented on PR #12784:
URL: https://github.com/apache/kafka/pull/12784#issuecomment-1297203987

   @sudeshwasnik Good point. I think with the code base as it is right now, we do get the invariant that asynchronous failures occur if and only if an offset is dispatched to `Producer::send`.
   
   I'd still like to see coverage for (and handling of) this case if possible, though, since we may modify the offset writer, offset backing store, or Kafka log classes in a way that causes the callback to be invoked without the record making it to `Producer::send`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org