You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/30 12:20:17 UTC

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request #138: [FLINK-26924] Rename docker image and helm chart to flink-kubernetes-operator

mbalassi opened a new pull request #138:
URL: https://github.com/apache/flink-kubernetes-operator/pull/138


   I aimed to update all externally released mentions of `flink-operator` to `flink-kubernetes-operator` 
   
   I left references to it within the helm chart itself, for example the k8s role used by the operator is still called `flink-operator` by default, templates are still prefixed with `flink-operator` etc. 
   Another area where I did leave `flink-operator` is in our JUnit tests, for example for test namespaces.
   
   Let me know if you prefer deeper with this effort, in these cases I felt that these mentions are either explicitly internal or only exists within the k8s cluster, explicitly linked to the k8s operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on a change in pull request #138: [FLINK-26924] Rename docker image and helm chart to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
mbalassi commented on a change in pull request #138:
URL: https://github.com/apache/flink-kubernetes-operator/pull/138#discussion_r838482808



##########
File path: .github/workflows/docker_push.yml
##########
@@ -54,7 +54,7 @@ jobs:
         uses: docker/metadata-action@v3
         with:
           images: |
-            ghcr.io/${{ github.repository_owner }}/flink-operator
+            ghcr.io/${{ github.repository }}

Review comment:
       `github.repository_owner` == `apache`
   `github.repository` == `apache/flink-kubernetes-operator`
   
   In short now that the image name equals the repo name I can write this shorter.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #138: [FLINK-26924] Rename docker image and helm chart to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #138:
URL: https://github.com/apache/flink-kubernetes-operator/pull/138#discussion_r838477455



##########
File path: .github/workflows/docker_push.yml
##########
@@ -54,7 +54,7 @@ jobs:
         uses: docker/metadata-action@v3
         with:
           images: |
-            ghcr.io/${{ github.repository_owner }}/flink-operator
+            ghcr.io/${{ github.repository }}

Review comment:
       why was /flink-operator removed here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on a change in pull request #138: [FLINK-26924] Rename docker image and helm chart to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
mbalassi commented on a change in pull request #138:
URL: https://github.com/apache/flink-kubernetes-operator/pull/138#discussion_r838484940



##########
File path: .github/workflows/docker_push.yml
##########
@@ -54,7 +54,7 @@ jobs:
         uses: docker/metadata-action@v3
         with:
           images: |
-            ghcr.io/${{ github.repository_owner }}/flink-operator
+            ghcr.io/${{ github.repository }}

Review comment:
       You can check the image generated [here](https://github.com/apache/flink-kubernetes-operator/runs/5753844849?check_suite_focus=true)
   <img width="1289" alt="Screenshot 2022-03-30 at 14 29 48" src="https://user-images.githubusercontent.com/5990983/160834839-91ada7c1-d6aa-44b8-b0c3-365b23740956.png">
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #138: [FLINK-26924] Rename docker image and helm chart to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
mbalassi merged pull request #138:
URL: https://github.com/apache/flink-kubernetes-operator/pull/138


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org