You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Ankur (JIRA)" <ji...@apache.org> on 2010/04/16 07:49:26 UTC

[jira] Created: (PIG-1379) Jars registered from command line should override the ones present in the script

Jars registered from command line should override the ones present in the script 
---------------------------------------------------------------------------------

                 Key: PIG-1379
                 URL: https://issues.apache.org/jira/browse/PIG-1379
             Project: Pig
          Issue Type: Improvement
            Reporter: Ankur
             Fix For: 0.7.0


Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding reassigned PIG-1379:
---------------------------------

    Assignee: Richard Ding

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1379:
------------------------------

    Attachment: PIG-1379.patch

re-sync with trunk.

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch, PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich resolved PIG-1379.
---------------------------------

    Resolution: Won't Fix

This is a non-backward compatible fix and it is not clear why we need to make it. Parameter substitution can be used to drive execution from command line

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890883#action_12890883 ] 

Alan Gates commented on PIG-1379:
---------------------------------

The change I'm concerned about is that, if I understand the JIRA correctly, we're changing which jars take precedence.  Where previously we would have given precedence to jars indicated in the Pig Latin script, now we'll give precedence to those indicated on the command line.  Is that correct?

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch, PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1379:
------------------------------

    Status: Open  (was: Patch Available)

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch, PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1379:
------------------------------

    Status: Patch Available  (was: Open)

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch, PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1379:
------------------------------

    Attachment: PIG-1379.patch

Use Hadoop GenericOptionsParser in Pig Main so that users can use -Dpig.additional.jars in command line to register jars for UDFs.

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1379:
------------------------------

    Status: Patch Available  (was: Open)

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890157#action_12890157 ] 

Hadoop QA commented on PIG-1379:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449873/PIG-1379.patch
  against trunk revision 965559.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/346/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/346/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/346/console

This message is automatically generated.

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890835#action_12890835 ] 

Richard Ding commented on PIG-1379:
-----------------------------------

The command line option -j doesn't work (PIG-348). We decided to remove this option and directly use -Dpig.additional.jars instead (this system setting has been supported by Pig for some time). The change is that now Pig Main directly accepts this option. 

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch, PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1379:
------------------------------

    Attachment:     (was: PIG-1379.patch)

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891815#action_12891815 ] 

Richard Ding commented on PIG-1379:
-----------------------------------

Alan, I got your point. I now think that we should reconsider this feature request. It isn't clear to me why this is useful. Users can use parameter substitution if they don't want to change the Pig scripts. 

I moved the posted patch to PIG-348. 

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates updated PIG-1379:
----------------------------

    Hadoop Flags: [Incompatible change]

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1379:
--------------------------------

    Fix Version/s: 0.8.0
                       (was: 0.7.0)

Pig 0.7.0 is frozen. Moving fix version to 0.8.0

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>             Fix For: 0.8.0
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1379:
------------------------------

    Status: Open  (was: Patch Available)

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1379) Jars registered from command line should override the ones present in the script

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890316#action_12890316 ] 

Alan Gates commented on PIG-1379:
---------------------------------

Won't this cause a backward compatibility issue?  Have we determined we're willing to make this semantic change in 0.8?

> Jars registered from command line should override the ones present in the script 
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-1379
>                 URL: https://issues.apache.org/jira/browse/PIG-1379
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ankur
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1379.patch
>
>
> Jars that are registered from the command line when executing the pig script should override the ones that are specified via 'register' in the pig script itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.