You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Mingfai Ma (JIRA)" <ji...@apache.org> on 2009/04/23 19:07:30 UTC
[jira] Updated: (DROIDS-49) Could started/taskDate of LinkTask not
to be final?
[ https://issues.apache.org/jira/browse/DROIDS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingfai Ma updated DROIDS-49:
-----------------------------
Attachment: DROIDS-49.patch
- make started non-final
- add a setter
p.s. maybe we should consider to re-name "started" to "taskDate" or rename "getTaskDate()" to "getStarted()"
> Could started/taskDate of LinkTask not to be final?
> ---------------------------------------------------
>
> Key: DROIDS-49
> URL: https://issues.apache.org/jira/browse/DROIDS-49
> Project: Droids
> Issue Type: Improvement
> Components: core
> Reporter: Mingfai Ma
> Priority: Minor
> Attachments: DROIDS-49.patch
>
>
> started/taskDate should be final, but it caused a problem to me in doing unit test that a huge number of LinkTask are to be created with different started date
> my suggestion:
> 1. make started non-final
> 2. add a constructor
> by design, the 2nd one is better. but in terms of maintainability, it's better not to add too many constructors.
> The HttpCore design has some examples (http header of response?! sth like that) that final attributes are not necessarily be made as final/immune. I suggest just to make the started field non-final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.