You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Eason09053360 (via GitHub)" <gi...@apache.org> on 2026/09/14 14:32:24 UTC
[PR] Fix airflowctl pools export/import dropping pool team ownership [airflow]
Eason09053360 opened a new pull request, #73132:
URL: https://github.com/apache/airflow/pull/73132
## Why
Multi-team deployments assign a pool to a team through `team_name`, which decides who may use that
pool. `airflowctl pools export` never wrote the field and `airflowctl pools import` never read it
back, so a backup/restore cycle silently dropped that ownership.
Worse than an incomplete file: `PoolsOperations.bulk` serialises with a plain `model_dump()`, so
the omitted field still goes out as `"team_name": null`, and `BulkPoolService.handle_bulk_create`
treats it as explicitly provided and writes it over the existing row. `airflowctl pools import
--action-on-existing-key overwrite` therefore clears the team on pools that had one, and reports
success.
`airflow pools export` / `import` — which these commands supersede, and which already carry a
`@deprecated_for_airflowctl` notice — do round-trip `team_name`. The field reached the old CLI in
#68110 and was never carried over, so this only bites users who followed the migration notice.
## What
In `airflow-ctl/src/airflowctl/ctl/commands/pool_command.py`, `export` now emits `team_name` and
`_import_helper` reads it back with `pool_config.get("team_name")` — the same spelling
`pool_import_helper` uses in the command this one replaces, so files written before this change
still import.
`test_export_includes_team_name` and `test_import_forwards_team_name` cover the two halves; the
latter asserts on the serialised bulk body, so it pins what actually reaches the server. The
hand-rolled pool stubs in the existing export tests gained `team_name` to stay in step with
`PoolResponse`.
### Open question
A hand-written file that *omits* `team_name` still sends null and still clears the team on
overwrite. That is unchanged here — same root cause as `description` and `include_deferred` being
reset to their defaults: `bulk()` sends every field unconditionally, defeating the server's
`exclude_unset=True` guard. Fixing it means changing what `bulk()` serialises, which shifts
overwrite semantics for those fields too and needs the same treatment in `connection_command` and
`variable_command`. (`exclude_none=True`, as the sibling `pools.create` / `pools.update` use, is
not enough — `description` defaults to `""` and `include_deferred` to `False`.) Happy to open that
separately if you agree it should be split.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5)
Generated-by: Claude Code (Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix airflowctl pools export/import dropping pool team ownership [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #73132:
URL: https://github.com/apache/airflow/pull/73132#issuecomment-6211320004
### Backport successfully created: airflow-ctl/v0-1-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>airflow-ctl/v0-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/74846"><img src="https://img.shields.io/badge/PR-74846-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix airflowctl pools export/import dropping pool team ownership [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #73132:
URL: https://github.com/apache/airflow/pull/73132#issuecomment-5839082148
Hello @Eason09053360 - thank you for your contributions to Apache Airflow!
The Airflow community has introduced a limit of **5 open pull requests at a time** for contributors without write access to the repository. You currently have 33 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
* #70935 - Return only the latest Dag version from iter_all_latest_version_dags
* #72145 - Fix airflow config get-value silently succeeding on a missing option
* #72468 - Fix airflowctl tracebacks on an unusable credentials file
* #72600 - Make suppress_logs_and_warning CLI decorator return the wrapped result
* #72656 - Fix dateless dag.test and tasks test destroying unrelated Dag runs
* #72675 - Fix airflowctl commands crashing instead of printing their result
* #72893 - Show a clean error when airflow backfill create targets an unknown Dag
* #72941 - Fix tasks clear --task-regex matching as a plain substring
* #73033 - Speed up airflow dags list on deployments with many Dags
* #73070 - Fix airflow dags next-execution crashing on --field data_interval.start
* #73083 - Fix airflow connections import corrupting JSON values in .env files
* #73112 - Fix structlog log assertions never matching a single-field dict
* #73120 - Fix misleading type errors from expand_kwargs and default_args
* #73121 - Fix bare traceback from kubernetes cleanup-pods without kube config
* #73132 - Fix airflowctl pools export/import dropping pool team ownership
* #73157 - Mask extra and credentials in connections list --hide-sensitive
* #73228 - Fix missing task alert emails on Dags using native template rendering
* #73348 - Stop providers lazy-loaded from writing the default config
* #73371 - Fix api-server --apps silently dropping apps and accepting typos
* #73373 - Fix Task SDK dry-run mode crashing on task instance start
* #73377 - Fix CLI --bundle-name finding no Dags in Git bundles
* #73379 - Fix empty audit log dag_id for DAG.cli() subcommands
* #73387 - Drop ignored --bundle-name and --dagfile-path from DAG.cli()
* #73400 - Fix indexing mapped task results with a NumPy integer
* #73409 - Respect maximum_page_limit in batch list endpoints
* #73422 - Stop the JWT revocation check stalling the API server event loop
* #73424 - Fix task instance 404 detail being a JSON array instead of a string
* #73463 - API: Remove unreachable Accept branch and last deprecated 422 alias
* #73465 - API: Cap run_ids on the grid TI summaries stream endpoint
* #73472 - Rate-limit JWKS fetch attempts while the endpoint is down
* #73514 - UI: Fix grid columns vanishing when a Dag version has been cleaned
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
* #73141 - Fix scheduler refusing to start when [scheduler] only_idle is enabled
* #73154 - Batch Team lookups when syncing Dag bundles to the database
This is **not** a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.
What we ask you to do is to make your **first prioritization decision**: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or `gh pr reopen <PR_NUMBER> --repo apache/airflow`. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.
While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.
Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix airflowctl pools export/import dropping pool team ownership [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #73132: Fix airflowctl pools export/import dropping pool team ownership
URL: https://github.com/apache/airflow/pull/73132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix airflowctl pools export/import dropping pool team ownership [airflow]
Posted by "Eason09053360 (via GitHub)" <gi...@apache.org>.
Eason09053360 commented on PR #73132:
URL: https://github.com/apache/airflow/pull/73132#issuecomment-6206385303
> Should we wrap the `bulk()` call in try/except so this surfaces as a `SystemExit` message instead of a traceback? It wouldn't change the rejection itself the whole-batch behaviour is a server-side contract question, but the command reports every other failure that way.
Thanks for reviewing! Test that traceback comes from this branch predating #73307, which made `safe_call_command` catch non-JSON errors such as the bare 500 a nonexistent `team_name` gets. Rebased onto main, the same import exits 1 with `Server response error: …`, so I've left `_import_helper` as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix airflowctl pools export/import dropping pool team ownership [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 merged PR #73132:
URL: https://github.com/apache/airflow/pull/73132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org