You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/10/09 12:52:22 UTC

[GitHub] [commons-collections] garydgregory commented on pull request #258: WIP: Simplify bloom filters

garydgregory commented on pull request #258:
URL: https://github.com/apache/commons-collections/pull/258#issuecomment-939292388


   Just some general comments: 
   
   For now only make public or protected what must be. We can open up the API in the future. When we release an API, we lock in binary support.
   
   Add Javadoc since tags to new types.
   
   Close HTML tags in Javadoc. For example, match <p> with </p>
   
   Hopefully someone can get into the nitty gritty. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org