[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #677: fix(c/driver/snowflake): fix validation test failures

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #677:
URL: https://github.com/apache/arrow-adbc/pull/677#discussion_r1190386701


##########
c/validation/adbc_validation.cc:
##########
@@ -1248,11 +1258,10 @@ void StatementTest::TestSqlIngestSample() {
               IsOkStatus(&error));
 
   ASSERT_THAT(AdbcStatementNew(&connection, &statement, &error), IsOkStatus(&error));
-  ASSERT_THAT(
-      AdbcStatementSetSqlQuery(
-          &statement, "SELECT * FROM bulk_ingest ORDER BY \"int64s\" ASC NULLS FIRST",
-          &error),
-      IsOkStatus(&error));
+  ASSERT_THAT(AdbcStatementSetSqlQuery(
+                  &statement, "SELECT * FROM bulk_ingest ORDER BY int64s ASC NULLS FIRST",

Review Comment:
   we probably need a table-name-quote quirk or else just make these queries provided as part of the quirks, I expect



##########
go/adbc/driver/snowflake/record_reader.go:
##########
@@ -219,7 +219,7 @@ func getTransformer(sc *arrow.Schema, ld gosnowflake.ArrowStreamLoader) (*arrow.
 		default:
 			transformers[i] = identCol
 		}
-
+		f.Name = strings.ToLower(f.Name)

Review Comment:
   Hmm, do we want to unconditionally do this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org