You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/01/21 19:11:59 UTC

Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4449
    https://issues.apache.org/jira/browse/MESOS-4449


Repository: mesos


Description
-------

This fixes a `NULL` pointer dereference erroneously added as part of introducing an output operator for the `Executor` struct in https://reviews.apache.org/r/39569.


Diffs
-----

  src/slave/slave.cpp e23c3295c8ebed580751a5aabaf26e1773c54859 

Diff: https://reviews.apache.org/r/42605/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar

Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115895
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Jan. 22, 2016, 3:57 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:57 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
>     https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes a `NULL` pointer dereference erroneously added as part of introducing an output operator for the `Executor` struct in https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

Posted by Shuai Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115852
-----------------------------------------------------------

Ship it!


Ship It!

- Shuai Lin


On Jan. 22, 2016, 3:57 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:57 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
>     https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes a `NULL` pointer dereference erroneously added as part of introducing an output operator for the `Executor` struct in https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 3:57 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Added `frameworkId` in log message too.


Bugs: MESOS-4449
    https://issues.apache.org/jira/browse/MESOS-4449


Repository: mesos


Description
-------

This fixes a `NULL` pointer dereference erroneously added as part of introducing an output operator for the `Executor` struct in https://reviews.apache.org/r/39569.


Diffs (updated)
-----

  src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 

Diff: https://reviews.apache.org/r/42605/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar

Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115825
-----------------------------------------------------------

Ship it!


Ship It!

- Klaus Ma


On Jan. 22, 2016, 2:11 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 2:11 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
>     https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes a `NULL` pointer dereference erroneously added as part of introducing an output operator for the `Executor` struct in https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e23c3295c8ebed580751a5aabaf26e1773c54859 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115751
-----------------------------------------------------------


Patch looks great!

Reviews applied: [42605]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 21, 2016, 6:11 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 6:11 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
>     https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes a `NULL` pointer dereference erroneously added as part of introducing an output operator for the `Executor` struct in https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e23c3295c8ebed580751a5aabaf26e1773c54859 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

Posted by Shuai Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115819
-----------------------------------------------------------



src/slave/slave.cpp (line 2112)
<https://reviews.apache.org/r/42605/#comment176889>

    Maybe we can also include the `frameworkId` in the log message?


- Shuai Lin


On Jan. 21, 2016, 6:11 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 6:11 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
>     https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes a `NULL` pointer dereference erroneously added as part of introducing an output operator for the `Executor` struct in https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e23c3295c8ebed580751a5aabaf26e1773c54859 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>