[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions
URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375336823
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
 ##########
 @@ -99,6 +99,11 @@ public MaterializedViewHandler() {
      */
     public void processCreateMaterializedView(CreateMaterializedViewStmt addMVClause, Database db, OlapTable olapTable)
             throws DdlException, AnalysisException {
+
+        if (olapTable.hasTempPartition(null)) {
 
 Review comment:
   This check is strange. we could add a `existTempPartition` method to olapTable, and  add a `isEmpty` method to 
   TempPartitions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org