You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "liuyongvs (via GitHub)" <gi...@apache.org> on 2024/12/05 03:46:25 UTC
[PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
liuyongvs opened a new pull request, #25742:
URL: https://github.com/apache/flink/pull/25742
## What is the purpose of the change
A bit reasoning for the change
high calcite version has fixed, current calcite version is 1.34
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25742:
URL: https://github.com/apache/flink/pull/25742#issuecomment-2519030224
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f35b91ef62bba2251a2aa6c267daa9abe24fff25",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f35b91ef62bba2251a2aa6c267daa9abe24fff25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f35b91ef62bba2251a2aa6c267daa9abe24fff25 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25742:
URL: https://github.com/apache/flink/pull/25742#issuecomment-2520389087
Reviewed by Chi on 05/12/24 Need a committer to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #25742:
URL: https://github.com/apache/flink/pull/25742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25742:
URL: https://github.com/apache/flink/pull/25742#discussion_r1874036818
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/SortFetchZeroRuleTest.scala:
##########
@@ -22,11 +22,12 @@ import org.apache.flink.table.planner.plan.optimize.program.{BatchOptimizeContex
import org.apache.flink.table.planner.utils.TableTestBase
import org.apache.calcite.plan.hep.HepMatchOrder
+import org.apache.calcite.rel.rules.PruneEmptyRules
import org.apache.calcite.tools.RuleSets
import org.junit.jupiter.api.{BeforeEach, Test}
-/** Test for [[FlinkLimit0RemoveRule]]. */
-class FlinkLimit0RemoveRuleTest extends TableTestBase {
+/** Test for [[PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE]]. */
+class SortFetchZeroRuleTest extends TableTestBase {
Review Comment:
I don\t think we need to rename it.
The new name says nothing about the intention of the test.
Instead of renaming I would suggest to change a javadoc something like
Former test for `FlinkLimit0RemoveRule` which now replaced by Calcite's `PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on PR #25742:
URL: https://github.com/apache/flink/pull/25742#issuecomment-2520136186
hi @snuyanzin will you help review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #25742:
URL: https://github.com/apache/flink/pull/25742#discussion_r1875174539
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/SortFetchZeroRuleTest.scala:
##########
@@ -22,11 +22,12 @@ import org.apache.flink.table.planner.plan.optimize.program.{BatchOptimizeContex
import org.apache.flink.table.planner.utils.TableTestBase
import org.apache.calcite.plan.hep.HepMatchOrder
+import org.apache.calcite.rel.rules.PruneEmptyRules
import org.apache.calcite.tools.RuleSets
import org.junit.jupiter.api.{BeforeEach, Test}
-/** Test for [[FlinkLimit0RemoveRule]]. */
-class FlinkLimit0RemoveRuleTest extends TableTestBase {
+/** Test for [[PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE]]. */
+class SortFetchZeroRuleTest extends TableTestBase {
Review Comment:
fixed @snuyanzin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on PR #25742:
URL: https://github.com/apache/flink/pull/25742#issuecomment-2530191088
hi @snuyanzin i have addressed your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org