You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/29 22:59:17 UTC

[GitHub] [beam] dpcollins-google commented on a change in pull request #14365: [BEAM-10884] - Adding tests to PubSubTableProviderIT to test the proto support added as part of [BEAM-11659]

dpcollins-google commented on a change in pull request #14365:
URL: https://github.com/apache/beam/pull/14365#discussion_r603664447



##########
File path: sdks/java/extensions/protobuf/src/test/proto/payload_messages.proto
##########
@@ -42,3 +42,18 @@ message SimpleMessage {
   int32 id = 1;
   string name = 2;
 }
+
+message NameMessage {

Review comment:
       possible nit: I'd use less-simple messages, at least one of which has a submessage or repeated field? TestMessage with ItMessage above would work well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org