You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/01/29 11:57:23 UTC
[GitHub] [incubator-celeborn] kaijchen opened a new pull request, #1183: [CELEBORN-248] Non-ASCII characters in source code
kaijchen opened a new pull request, #1183:
URL: https://github.com/apache/incubator-celeborn/pull/1183
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1183: [CELEBORN-248] Non-ASCII characters in source code
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1183:
URL: https://github.com/apache/incubator-celeborn/pull/1183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1183: [CELEBORN-248] Non-ASCII characters in source code
Posted by codecov.
codecov[bot] commented on PR #1183:
URL: https://github.com/apache/incubator-celeborn/pull/1183#issuecomment-1407645060
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1183?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1183](https://codecov.io/gh/apache/incubator-celeborn/pull/1183?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef7dcd2) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/8611a6440050553d6d4b0bb410daacc90c7297e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8611a64) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1183 +/- ##
============================================
+ Coverage 26.93% 26.97% +0.04%
- Complexity 770 774 +4
============================================
Files 203 203
Lines 17339 17339
Branches 1878 1878
============================================
+ Hits 4669 4675 +6
+ Misses 12345 12343 -2
+ Partials 325 321 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/celeborn/common/haclient/RssHARetryClient.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vaGFjbGllbnQvUnNzSEFSZXRyeUNsaWVudC5qYXZh) | `73.04% <ø> (ø)` | |
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.73% <0.00%> (+2.46%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org