[jira] [Commented] (STORM-1965) Show warning message when dot ('.') is used for topology name or component name

["Jungtaek Lim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374226#comment-15374226 ] 

Jungtaek Lim commented on STORM-1965:
-------------------------------------

Kafka has similar issue. Kafka allows to use dot for naming topic but automatically convert to underscore due to metric names. It would make collision between dot and underscore so Kafka needs to handle another collision check.

They seem to show warning message on creating topic.
{quote} 
WARNING: Due to limitations in metric names, topics with a period ('.') or underscore ('_') could collide. To avoid issues it is best to use either, but not both.
{quote}

We can do the same.

Btw, they also restrict characters consisting topic name. It seems related to file system (I don't know about internal, just guessing about restricting '..') but I think it would be good to have restriction on topology name and component name. Just two cents.

> Show warning message when dot ('.') is used for topology name or component name
> -------------------------------------------------------------------------------
>
>                 Key: STORM-1965
>                 URL: https://issues.apache.org/jira/browse/STORM-1965
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>            Priority: Minor
>
> We're exposing metrics to metrics consumer, and most of them are storing metrics to time-series DB.
> Well-known common rule of generating metric name for these DB is using dot ('.') to separate parts, so that it can be parsed easily when needed.
> For example, graphite separates part of metric name to dot, and support wildcard for each part. Note that it doesn't support wildcard matching multiple parts.
> Since topology name or component name having dots are not common case to use case of user, I think we can warn users to not having dots on their topology name or component name. We can even restrict to not having dots if we all are really OK with this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)