[GitHub] [gobblin] homatthew commented on a diff in pull request #3490: [GOBBLIN-1613] Add metadata writers field to GMCE schema

[GitBox <gi...@apache.org>]

homatthew commented on code in PR #3490:
URL: https://github.com/apache/gobblin/pull/3490#discussion_r843197001


##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/GobblinMCEWriter.java:
##########
@@ -294,12 +298,14 @@ public void writeEnvelope(RecordEnvelope<GenericRecord> recordEnvelope) throws I
   }
 
   // Add fault tolerant ability and make sure we can emit GTE as desired
-  private void write(RecordEnvelope recordEnvelope, ConcurrentHashMap newSpecsMap, ConcurrentHashMap oldSpecsMap, HiveSpec spec) throws IOException {
+  @VisibleForTesting
+  void write(RecordEnvelope<GenericRecord> recordEnvelope, ConcurrentHashMap newSpecsMap, ConcurrentHashMap oldSpecsMap, HiveSpec spec) throws IOException {

Review Comment:
   Entry point for calling writers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org