You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/03/03 01:35:30 UTC
Review Request 57264: Fixed
ProvisionerDockerPullerTest.ROOT_RecoverNestedOnReboot.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57264/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
Otherwise this test fails for me.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp 01c06828a05bcafd5ae40191625edbd507983a99
Diff: https://reviews.apache.org/r/57264/diff/1/
Testing
-------
sudo make check
Thanks,
Jiang Yan Xu
Re: Review Request 57264: Fixed
ProvisionerDockerPullerTest.ROOT_RecoverNestedOnReboot.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57264/#review167792
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57264]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 3, 2017, 1:35 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57264/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 1:35 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Otherwise this test fails for me.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 01c06828a05bcafd5ae40191625edbd507983a99
>
>
> Diff: https://reviews.apache.org/r/57264/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 57264: Fixed
ProvisionerDockerPullerTest.ROOT_RecoverNestedOnReboot.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57264/#review167780
-----------------------------------------------------------
Ship it!
Thanks for the patch!
Not yours, we should consider replace all `os::getcwd()` in this file to `sandbox.get`.
- Gilbert Song
On March 2, 2017, 5:35 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57264/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 5:35 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Otherwise this test fails for me.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 01c06828a05bcafd5ae40191625edbd507983a99
>
>
> Diff: https://reviews.apache.org/r/57264/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>