You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "linrrzqqq (via GitHub)" <gi...@apache.org> on 2026/05/08 09:59:46 UTC
[PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
linrrzqqq opened a new pull request, #63080:
URL: https://github.com/apache/doris/pull/63080
Problem Summary:
`AI_AGG` previously stored `QueryContext` in a process-level static pointer. Concurrent AI_AGG queries could overwrite that pointer, causing one query to read another query's AI resource metadata, query options, or timeout state.
The aggregate function instance now receives the query context from `AggFnEvaluator` and binds it to each AggregateFunctionAIAggData state when the state is created, reset, or deserialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4406962453
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (12/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63080_c7bc56a240973252fe7d5a646ccd2c55613cf1fd_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63080_c7bc56a240973252fe7d5a646ccd2c55613cf1fd_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 74.38% (27999/37643) |
| Line Coverage | 58.44% (304841/521663) |
| Region Coverage | 56.12% (256308/456715) |
| Branch Coverage | 57.57% (110649/192189) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4405524668
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4417202708
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4405513084
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #63080:
URL: https://github.com/apache/doris/pull/63080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4412213896
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (12/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63080_c7bc56a240973252fe7d5a646ccd2c55613cf1fd_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63080_c7bc56a240973252fe7d5a646ccd2c55613cf1fd_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.76% (27764/37643) |
| Line Coverage | 57.60% (300460/521663) |
| Region Coverage | 54.79% (250225/456715) |
| Branch Coverage | 56.34% (108283/192189) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4408411311
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (12/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63080_c7bc56a240973252fe7d5a646ccd2c55613cf1fd_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63080_c7bc56a240973252fe7d5a646ccd2c55613cf1fd_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.76% (27764/37643) |
| Line Coverage | 57.61% (300523/521663) |
| Region Coverage | 54.78% (250184/456715) |
| Branch Coverage | 56.36% (108314/192189) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4405599774
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ai_agg) isolate AI_AGG query_ctx per aggregate state [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63080:
URL: https://github.com/apache/doris/pull/63080#issuecomment-4417202902
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org