[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4233: ci xserver for commit validation matrix

[GitBox <gi...@apache.org>]

matthiasblaesing commented on code in PR #4233:
URL: https://github.com/apache/netbeans/pull/4233#discussion_r911412141


##########
webcommon/web.inspect/src/org/netbeans/modules/web/inspect/ui/CssStylesPanelProviderImpl.java:
##########
@@ -139,7 +139,6 @@ private void initNoStylesLabel() {
         noStylesLabel.setHorizontalAlignment(SwingConstants.CENTER);
         noStylesLabel.setVerticalAlignment(SwingConstants.CENTER);
         noStylesLabel.setEnabled(false);
-        noStylesLabel.setBackground(new BeanTreeView().getViewport().getView().getBackground());

Review Comment:
   I tested this on current master - the original code works and is not broken. I admit, that it is questionable, but it works ;-)
   
   From my perspective it would be good to either guard this with a try-catch or with a null check, with a comment, that the null case happens in test variant. (comment matches all cases)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists