You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (JIRA)" <ji...@apache.org> on 2011/05/05 11:44:03 UTC
[jira] [Created] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
SimpleTextCodec needs SimpleText DocValues impl
-----------------------------------------------
Key: LUCENE-3074
URL: https://issues.apache.org/jira/browse/LUCENE-3074
Project: Lucene - Java
Issue Type: Task
Components: Index, Search
Affects Versions: CSF branch
Reporter: Simon Willnauer
Assignee: Michael McCandless
Fix For: CSF branch
currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189204#comment-13189204 ]
Simon Willnauer commented on LUCENE-3074:
-----------------------------------------
FYI I am working on this. Robert you are not on it right now, right?
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer reassigned LUCENE-3074:
---------------------------------------
Assignee: Simon Willnauer (was: Michael McCandless)
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213672#comment-13213672 ]
Robert Muir commented on LUCENE-3074:
-------------------------------------
first thoughts: looks nice! Thanks for working on this!
I will try to take a look later, I noticed a few imports from lucene40 codec into simpletext (which i think we should avoid),
but I think these were just javadocs relics!
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: LUCENE-3074.patch
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3074:
------------------------------------
Affects Version/s: (was: CSF branch)
4.0
Fix Version/s: (was: CSF branch)
4.0
fix once on trunk
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Fix For: 4.0
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3074:
------------------------------------
Attachment: LUCENE-3074.patch
merged with trunk...
SimpleTextPerDocProducer still uses 2 lucene40 classes DocValuesArray & DocValuesReaderBase.
I think DocValues array is generally useful and should go to o.a.l.codec and we can rename DocValuesReaderBase to PerDocProducerBase and move to o.a.l.codec too. Thoughts?
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: LUCENE-3074.patch, LUCENE-3074.patch
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3074:
------------------------------------
Priority: Blocker (was: Major)
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163992#comment-13163992 ]
Robert Muir commented on LUCENE-3074:
-------------------------------------
I'm gonna take a stab at this, because we really want to have multiple implementations to ensure the abstract api is good,
and doesnt have any assumptions about the current implementation.
Any issues would be harder to debug if our first alternative implementation was something like crazy 3.x norms versus an easy
plain text impl.
ill commit LUCENE-3622 to a branch and start playing around.
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Fix For: 4.0
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224221#comment-13224221 ]
Robert Muir commented on LUCENE-3074:
-------------------------------------
Thanks Simon!
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: LUCENE-3074.patch, LUCENE-3074.patch
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189213#comment-13189213 ]
Robert Muir commented on LUCENE-3074:
-------------------------------------
No... i got caught up in 3622 trying to factor out the lucene40 implementation better.
But a lot of those issues are now fixed (e.g. we have a default merge implementation).
I just marked 3622 closed since I think the goals of that issue are now resolved.
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3074:
------------------------------------
Attachment: LUCENE-3074.patch
here is a first patch adding SimpleTextDV and replacing SimpleTextNorms with it directly.
I had to change some upstream classes and especially the merging done in the DocValuesConsumer which used the "wrong" type for merging. In general we should use the target type instead of the source type and sources need to implement getBytes and do auto conversion otherwise type promotion doesn't work.
this patch writes individual files per field like sep codec which made things a lot easier and is maybe better suited for SimpleText
comments welcome
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: LUCENE-3074.patch
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer resolved LUCENE-3074.
-------------------------------------
Resolution: Fixed
Lucene Fields: New,Patch Available (was: New)
committed to trunk in revision 1297920
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: LUCENE-3074.patch, LUCENE-3074.patch
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3074) SimpleTextCodec needs SimpleText
DocValues impl
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221009#comment-13221009 ]
Simon Willnauer commented on LUCENE-3074:
-----------------------------------------
any comments on this? I don't want this to go out of date too much
> SimpleTextCodec needs SimpleText DocValues impl
> -----------------------------------------------
>
> Key: LUCENE-3074
> URL: https://issues.apache.org/jira/browse/LUCENE-3074
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: LUCENE-3074.patch
>
>
> currently SimpleTextCodec uses binary docValues we should move that to a simple text impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org