You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/09/10 05:35:19 UTC

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

eolivelli commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.
URL: https://github.com/apache/zookeeper/pull/1084#discussion_r322558927
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java
 ##########
 @@ -274,7 +274,7 @@ public void respondToServer(byte[] serverToken, ClientCnxn cnxn) {
             } catch (SaslException e) {
                 LOG.error("SASL authentication failed using login context '"
                           + this.getLoginContext()
-                          + "' with exception: {}", e);
 
 Review comment:
   I think slf4 still logs the exception as exceptions are handled in a special way.
   Doesn't it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services