You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by Andreas Neumann <an...@apache.org> on 2014/04/12 11:16:12 UTC
Review Request 20279: Fixes a problem where empty list of runnables to debug
causes appmaster to crash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20279/
-----------------------------------------------------------
Review request for Twill.
Bugs: TWILL-72
https://issues.apache.org/jira/browse/TWILL-72
Repository: twill
Description
-------
empty list is serialized as null, but deserialization does not check for null.
Diffs
-----
twill-core/src/main/java/org/apache/twill/internal/JvmOptions.java a260f5b
twill-core/src/main/java/org/apache/twill/internal/json/JvmOptionsCodec.java a1b7eb9
twill-core/src/test/java/org/apache/twill/internal/json/JvmOptionsCodecTest.java 66187f2
twill-yarn/src/test/java/org/apache/twill/yarn/DebugTestRun.java daf0bc1
Diff: https://reviews.apache.org/r/20279/diff/
Testing
-------
added unit tests both for the serialization and for the debug run.
Thanks,
Andreas Neumann
Re: Review Request 20279: Fixes a problem where empty list of runnables to
debug causes appmaster to crash
Posted by Terence Yim <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20279/#review40292
-----------------------------------------------------------
Ship it!
Ship It!
- Terence Yim
On April 12, 2014, 3:55 p.m., Andreas Neumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20279/
> -----------------------------------------------------------
>
> (Updated April 12, 2014, 3:55 p.m.)
>
>
> Review request for Twill.
>
>
> Bugs: TWILL-72
> https://issues.apache.org/jira/browse/TWILL-72
>
>
> Repository: twill
>
>
> Description
> -------
>
> empty list is serialized as null, but deserialization does not check for null.
>
>
> Diffs
> -----
>
> twill-core/src/main/java/org/apache/twill/internal/JvmOptions.java a260f5b
> twill-core/src/main/java/org/apache/twill/internal/json/JvmOptionsCodec.java a1b7eb9
> twill-core/src/test/java/org/apache/twill/internal/json/JvmOptionsCodecTest.java 66187f2
> twill-yarn/src/test/java/org/apache/twill/yarn/DebugTestRun.java daf0bc1
>
> Diff: https://reviews.apache.org/r/20279/diff/
>
>
> Testing
> -------
>
> added unit tests both for the serialization and for the debug run.
>
>
> Thanks,
>
> Andreas Neumann
>
>
Re: Review Request 20279: Fixes a problem where empty list of runnables to
debug causes appmaster to crash
Posted by Andreas Neumann <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20279/
-----------------------------------------------------------
(Updated April 12, 2014, 3:55 p.m.)
Review request for Twill.
Changes
-------
Fixing a checkstyle issue.
Bugs: TWILL-72
https://issues.apache.org/jira/browse/TWILL-72
Repository: twill
Description
-------
empty list is serialized as null, but deserialization does not check for null.
Diffs (updated)
-----
twill-core/src/main/java/org/apache/twill/internal/JvmOptions.java a260f5b
twill-core/src/main/java/org/apache/twill/internal/json/JvmOptionsCodec.java a1b7eb9
twill-core/src/test/java/org/apache/twill/internal/json/JvmOptionsCodecTest.java 66187f2
twill-yarn/src/test/java/org/apache/twill/yarn/DebugTestRun.java daf0bc1
Diff: https://reviews.apache.org/r/20279/diff/
Testing
-------
added unit tests both for the serialization and for the debug run.
Thanks,
Andreas Neumann