You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@vxquery.apache.org by Riyafa Abdul Hameed <ri...@cse.mrt.ac.lk> on 2016/07/15 15:24:55 UTC
Issues if using a separate constructor for SimpleObjectUnion
Hi,
On attempting to create a separate constructor for SimpleObjectUnion I have
come across the following issues:
- Since there's no separate ValueTag for this SimpleObjectUnion
constructor, it is not possible to call a separate translate method when
this constructor is encountered.
- A new ValueTag for the constructor cannot be created since the
specification[1] doesn't mention about such a constructor.
Am I to proceed creating this new SimpleObjectUnion constructor? If so any
suggestions on how it could be done?
[1]
http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#section-json-value-construction
Thank you.
Yours sincerely,
Riyafa
--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa
Email: riyafa.12@cse.mrt.ac.lk
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>
Re: Issues if using a separate constructor for SimpleObjectUnion
Posted by Riyafa Abdul Hameed <ri...@cse.mrt.ac.lk>.
Hi,
I have squashed the commits to a single commit[1]
[1] https://github.com/apache/vxquery/pull/107
Thank you.
Yours sincerely,
Riyafa
On 18 July 2016 at 00:15, Preston Carman <pr...@apache.org> wrote:
> Posted comments.
>
> On Sun, Jul 17, 2016 at 4:45 AM, Riyafa Abdul Hameed <
> riyafa.12@cse.mrt.ac.lk> wrote:
>
>> Hi,
>>
>> I have removed the LOOKAHEAD(2) because it's not needed[1].
>>
>> [1] https://github.com/apache/vxquery/pull/100
>>
>> Thank you.
>>
>> Yours sincerely,
>> Riyafa
>>
>> On 16 July 2016 at 00:23, Riyafa Abdul Hameed <ri...@cse.mrt.ac.lk>
>> wrote:
>>
>>> Hi,
>>>
>>> Thank you for the suggestion. I have created a PR with the required
>>> changes [1].
>>>
>>> [1] https://github.com/apache/vxquery/pull/100
>>>
>>> Thank you.
>>>
>>> Yours sincerely,
>>> Riyafa
>>>
>>> On 15 July 2016 at 22:10, Till Westmann <ti...@apache.org> wrote:
>>>
>>>> Hi Riyafa,
>>>>
>>>> I think that it’s fine to add a new value for the Object union to the
>>>> ASTTag.
>>>> The grammar in the specification describes the syntax of the language,
>>>> but it
>>>> is up to the implementation to decide how to represent this internally.
>>>>
>>>> Please go ahead and create that tag for the new AST node.
>>>>
>>>> Cheers,
>>>> Till
>>>>
>>>> On 15 Jul 2016, at 8:24, Riyafa Abdul Hameed wrote:
>>>>
>>>> Hi,
>>>>>
>>>>> On attempting to create a separate constructor for SimpleObjectUnion I
>>>>> have
>>>>> come across the following issues:
>>>>>
>>>>>
>>>>> - Since there's no separate ValueTag for this SimpleObjectUnion
>>>>> constructor, it is not possible to call a separate translate method
>>>>> when
>>>>> this constructor is encountered.
>>>>> - A new ValueTag for the constructor cannot be created since the
>>>>> specification[1] doesn't mention about such a constructor.
>>>>>
>>>>> Am I to proceed creating this new SimpleObjectUnion constructor? If so
>>>>> any
>>>>> suggestions on how it could be done?
>>>>>
>>>>> [1]
>>>>>
>>>>> http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#section-json-value-construction
>>>>>
>>>>> Thank you.
>>>>>
>>>>> Yours sincerely,
>>>>>
>>>>> Riyafa
>>>>>
>>>>> --
>>>>> Riyafa Abdul Hameed
>>>>> Undergraduate, University of Moratuwa
>>>>>
>>>>> Email: riyafa.12@cse.mrt.ac.lk
>>>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>>>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
>>>>> <http://twitter.com/Riyafa1>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Riyafa Abdul Hameed
>>> Undergraduate, University of Moratuwa
>>>
>>> Email: riyafa.12@cse.mrt.ac.lk
>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
>>> <http://twitter.com/Riyafa1>
>>>
>>
>>
>>
>> --
>> Riyafa Abdul Hameed
>> Undergraduate, University of Moratuwa
>>
>> Email: riyafa.12@cse.mrt.ac.lk
>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
>> <http://twitter.com/Riyafa1>
>>
>
>
--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa
Email: riyafa.12@cse.mrt.ac.lk
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>
Re: Issues if using a separate constructor for SimpleObjectUnion
Posted by Preston Carman <pr...@apache.org>.
Posted comments.
On Sun, Jul 17, 2016 at 4:45 AM, Riyafa Abdul Hameed <
riyafa.12@cse.mrt.ac.lk> wrote:
> Hi,
>
> I have removed the LOOKAHEAD(2) because it's not needed[1].
>
> [1] https://github.com/apache/vxquery/pull/100
>
> Thank you.
>
> Yours sincerely,
> Riyafa
>
> On 16 July 2016 at 00:23, Riyafa Abdul Hameed <ri...@cse.mrt.ac.lk>
> wrote:
>
>> Hi,
>>
>> Thank you for the suggestion. I have created a PR with the required
>> changes [1].
>>
>> [1] https://github.com/apache/vxquery/pull/100
>>
>> Thank you.
>>
>> Yours sincerely,
>> Riyafa
>>
>> On 15 July 2016 at 22:10, Till Westmann <ti...@apache.org> wrote:
>>
>>> Hi Riyafa,
>>>
>>> I think that it’s fine to add a new value for the Object union to the
>>> ASTTag.
>>> The grammar in the specification describes the syntax of the language,
>>> but it
>>> is up to the implementation to decide how to represent this internally.
>>>
>>> Please go ahead and create that tag for the new AST node.
>>>
>>> Cheers,
>>> Till
>>>
>>> On 15 Jul 2016, at 8:24, Riyafa Abdul Hameed wrote:
>>>
>>> Hi,
>>>>
>>>> On attempting to create a separate constructor for SimpleObjectUnion I
>>>> have
>>>> come across the following issues:
>>>>
>>>>
>>>> - Since there's no separate ValueTag for this SimpleObjectUnion
>>>> constructor, it is not possible to call a separate translate method
>>>> when
>>>> this constructor is encountered.
>>>> - A new ValueTag for the constructor cannot be created since the
>>>> specification[1] doesn't mention about such a constructor.
>>>>
>>>> Am I to proceed creating this new SimpleObjectUnion constructor? If so
>>>> any
>>>> suggestions on how it could be done?
>>>>
>>>> [1]
>>>>
>>>> http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#section-json-value-construction
>>>>
>>>> Thank you.
>>>>
>>>> Yours sincerely,
>>>>
>>>> Riyafa
>>>>
>>>> --
>>>> Riyafa Abdul Hameed
>>>> Undergraduate, University of Moratuwa
>>>>
>>>> Email: riyafa.12@cse.mrt.ac.lk
>>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
>>>> <http://twitter.com/Riyafa1>
>>>>
>>>
>>
>>
>> --
>> Riyafa Abdul Hameed
>> Undergraduate, University of Moratuwa
>>
>> Email: riyafa.12@cse.mrt.ac.lk
>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
>> <http://twitter.com/Riyafa1>
>>
>
>
>
> --
> Riyafa Abdul Hameed
> Undergraduate, University of Moratuwa
>
> Email: riyafa.12@cse.mrt.ac.lk
> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
> <http://twitter.com/Riyafa1>
>
Re: Issues if using a separate constructor for SimpleObjectUnion
Posted by Riyafa Abdul Hameed <ri...@cse.mrt.ac.lk>.
Hi,
I have removed the LOOKAHEAD(2) because it's not needed[1].
[1] https://github.com/apache/vxquery/pull/100
Thank you.
Yours sincerely,
Riyafa
On 16 July 2016 at 00:23, Riyafa Abdul Hameed <ri...@cse.mrt.ac.lk>
wrote:
> Hi,
>
> Thank you for the suggestion. I have created a PR with the required
> changes [1].
>
> [1] https://github.com/apache/vxquery/pull/100
>
> Thank you.
>
> Yours sincerely,
> Riyafa
>
> On 15 July 2016 at 22:10, Till Westmann <ti...@apache.org> wrote:
>
>> Hi Riyafa,
>>
>> I think that it’s fine to add a new value for the Object union to the
>> ASTTag.
>> The grammar in the specification describes the syntax of the language,
>> but it
>> is up to the implementation to decide how to represent this internally.
>>
>> Please go ahead and create that tag for the new AST node.
>>
>> Cheers,
>> Till
>>
>> On 15 Jul 2016, at 8:24, Riyafa Abdul Hameed wrote:
>>
>> Hi,
>>>
>>> On attempting to create a separate constructor for SimpleObjectUnion I
>>> have
>>> come across the following issues:
>>>
>>>
>>> - Since there's no separate ValueTag for this SimpleObjectUnion
>>> constructor, it is not possible to call a separate translate method
>>> when
>>> this constructor is encountered.
>>> - A new ValueTag for the constructor cannot be created since the
>>> specification[1] doesn't mention about such a constructor.
>>>
>>> Am I to proceed creating this new SimpleObjectUnion constructor? If so
>>> any
>>> suggestions on how it could be done?
>>>
>>> [1]
>>>
>>> http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#section-json-value-construction
>>>
>>> Thank you.
>>>
>>> Yours sincerely,
>>>
>>> Riyafa
>>>
>>> --
>>> Riyafa Abdul Hameed
>>> Undergraduate, University of Moratuwa
>>>
>>> Email: riyafa.12@cse.mrt.ac.lk
>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
>>> <http://twitter.com/Riyafa1>
>>>
>>
>
>
> --
> Riyafa Abdul Hameed
> Undergraduate, University of Moratuwa
>
> Email: riyafa.12@cse.mrt.ac.lk
> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
> <http://twitter.com/Riyafa1>
>
--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa
Email: riyafa.12@cse.mrt.ac.lk
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>
Re: Issues if using a separate constructor for SimpleObjectUnion
Posted by Riyafa Abdul Hameed <ri...@cse.mrt.ac.lk>.
Hi,
Thank you for the suggestion. I have created a PR with the required changes
[1].
[1] https://github.com/apache/vxquery/pull/100
Thank you.
Yours sincerely,
Riyafa
On 15 July 2016 at 22:10, Till Westmann <ti...@apache.org> wrote:
> Hi Riyafa,
>
> I think that it’s fine to add a new value for the Object union to the
> ASTTag.
> The grammar in the specification describes the syntax of the language, but
> it
> is up to the implementation to decide how to represent this internally.
>
> Please go ahead and create that tag for the new AST node.
>
> Cheers,
> Till
>
> On 15 Jul 2016, at 8:24, Riyafa Abdul Hameed wrote:
>
> Hi,
>>
>> On attempting to create a separate constructor for SimpleObjectUnion I
>> have
>> come across the following issues:
>>
>>
>> - Since there's no separate ValueTag for this SimpleObjectUnion
>> constructor, it is not possible to call a separate translate method
>> when
>> this constructor is encountered.
>> - A new ValueTag for the constructor cannot be created since the
>> specification[1] doesn't mention about such a constructor.
>>
>> Am I to proceed creating this new SimpleObjectUnion constructor? If so any
>> suggestions on how it could be done?
>>
>> [1]
>>
>> http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#section-json-value-construction
>>
>> Thank you.
>>
>> Yours sincerely,
>>
>> Riyafa
>>
>> --
>> Riyafa Abdul Hameed
>> Undergraduate, University of Moratuwa
>>
>> Email: riyafa.12@cse.mrt.ac.lk
>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
>> <http://twitter.com/Riyafa1>
>>
>
--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa
Email: riyafa.12@cse.mrt.ac.lk
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>
Re: Issues if using a separate constructor for SimpleObjectUnion
Posted by Till Westmann <ti...@apache.org>.
Hi Riyafa,
I think that it’s fine to add a new value for the Object union to the
ASTTag.
The grammar in the specification describes the syntax of the language,
but it
is up to the implementation to decide how to represent this internally.
Please go ahead and create that tag for the new AST node.
Cheers,
Till
On 15 Jul 2016, at 8:24, Riyafa Abdul Hameed wrote:
> Hi,
>
> On attempting to create a separate constructor for SimpleObjectUnion I
> have
> come across the following issues:
>
>
> - Since there's no separate ValueTag for this SimpleObjectUnion
> constructor, it is not possible to call a separate translate method
> when
> this constructor is encountered.
> - A new ValueTag for the constructor cannot be created since the
> specification[1] doesn't mention about such a constructor.
>
> Am I to proceed creating this new SimpleObjectUnion constructor? If so
> any
> suggestions on how it could be done?
>
> [1]
> http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#section-json-value-construction
>
> Thank you.
>
> Yours sincerely,
>
> Riyafa
>
> --
> Riyafa Abdul Hameed
> Undergraduate, University of Moratuwa
>
> Email: riyafa.12@cse.mrt.ac.lk
> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
> <http://twitter.com/Riyafa1>