[jira] [Commented] (NIFI-5829) Create Lookup Controller Services for RecordSetWriter and RecordReader

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702132#comment-16702132 ] 

ASF GitHub Bot commented on NIFI-5829:
--------------------------------------

GitHub user patricker opened a pull request:

    https://github.com/apache/nifi/pull/3188

    NIFI-5829 Create Lookup Controller Services for RecordSetWriter and R…

    …ecordReader
    
    The Reader Lookup is a fairly small change, because the reader factory was already getting the FlowFile attributes passed in.
    
    The Writer Lookup on the other hand... I had to update the createWriter method to accept attributes, and then update a lot processors to pass in attributes. `getSchema` already accepted the attributes, interestingly enough.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/patricker/nifi NIFI-5829

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3188
    
----
commit d9d659682b49505362d2ae847f5d8cac67926af9
Author: Peter Wicks <pa...@...>
Date:   2018-11-17T04:46:07Z

    NIFI-5829 Create Lookup Controller Services for RecordSetWriter and RecordReader

----


> Create Lookup Controller Services for RecordSetWriter and RecordReader
> ----------------------------------------------------------------------
>
>                 Key: NIFI-5829
>                 URL: https://issues.apache.org/jira/browse/NIFI-5829
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>
> In the same way as the new DBCP Lookup Service, create lookup services for RecordSetWriter and RecordReader.
> This will help to make flows much more generic, and allow for some very flexible processors.
> Example: A processor like PutDatabaseRecord will be able to push to any database in any readable record format from a single processor by configuring everything through the lookup services.
> Example: ConvertRecord will be able to convert from any number of various input formats to a constant output format by using the RecordReader Lookup, and a fixed RecordSetWriter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)