[jira] [Commented] (HBASE-6460) hbck "-repairHoles" shortcut doesn't enable "-fixHdfsOrphans"

["Jie Huang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426596#comment-13426596 ] 

Jie Huang commented on HBASE-6460:
----------------------------------

bq. When you say ignore, do you mean treat it as a warning as opposed to a error?

Without that *-fixHdfsOrphans* option, the hbck won't try to fix the problem as you like.

Regarding the shortcut, from my perspective, we can let "-repairHoles" to fix both items at the same time, which is quite acceptable literally. And I wonder if it is OK to have another shortcut for "-fixAssignments -fixMeta", which aim to solve the meta related parts. And then we can combine any single option (like -fixHdfsHole) along with those options. What do you think?
                
> hbck "-repairHoles" shortcut doesn't enable "-fixHdfsOrphans"
> -------------------------------------------------------------
>
>                 Key: HBASE-6460
>                 URL: https://issues.apache.org/jira/browse/HBASE-6460
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jie Huang
>            Priority: Minor
>         Attachments: hbase-6460.patch
>
>
> According to the hbck's help info, shortcut - "-repairHoles" will enable "-fixHdfsOrphans" as below.
> {noformat}
>  -repairHoles      Shortcut for -fixAssignments -fixMeta -fixHdfsHoles -fixHdfsOrphans
> {noformat}
> However, in the implementation, the function "fsck.setFixHdfsOrphans(false);" is called in "-repairHoles". This is not consistent with the usage information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira