You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/10/22 00:16:37 UTC
[PR] refactor(frontend): remove unused ReportGenerationService members [texera]
aglinxinyuan opened a new pull request, #9087:
URL: https://github.com/apache/texera/pull/9087
### What changes were proposed in this PR?
Removes three unused members from `ReportGenerationService`: the private `isAIAssistantEnabled` field, the injected `http: HttpClient`, and the `AI_ASSISTANT_API_BASE_URL` constant. The now-unused `HttpClient` and `AppSettings` imports go too. **+2/−11 lines.** There is no behaviour change.
Nothing reads any of them, and nothing builds the service by hand; Angular DI creates it, so dropping a constructor parameter is safe. The spec drops its empty `HttpClient` stub, whose comment already noted that `http` is "injected by the service and never used".
### History
| | |
| --- | --- |
| **Introduced by** | #2816 (2024-10-15), "Enhancing Report Generation by Adding Story-teller Ai based on Ai flag", which added all three to this service. Its HTTP calls live in `AiAnalystService` |
| **Usage removed by** | **never used** |
They have been unused for the two years since they were added.
### Any related issues, documentation, discussions?
Closes #9084
### How was this PR tested?
No new tests.
From `frontend/`:
- `npx ng test --watch=false --include='**/report-generation.service.spec.ts' --include='**/menu.component.spec.ts'`: 2 files, 169 tests, all pass. These are the only specs that provide or inject the service.
- `npx tsc --noEmit -p src/tsconfig.app.json` and `-p src/tsconfig.spec.json`: clean.
- `yarn format:ci`: clean.
- `npx ng build`: success.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused report-generation members [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9087:
URL: https://github.com/apache/texera/pull/9087#issuecomment-6330350609
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Neilk1021`
You can notify them by mentioning `@Neilk1021` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused report-generation members [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9087:
URL: https://github.com/apache/texera/pull/9087#issuecomment-6331718527
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/9087?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.33%. Comparing base ([`3ba45ee`](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7ed759`](https://app.codecov.io/gh/apache/texera/commit/a7ed759a28261de47cbe36e2a1ca32979f94d6d1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9087 +/- ##
============================================
- Coverage 92.33% 92.33% -0.01%
Complexity 5045 5045
============================================
Files 1261 1261
Lines 54120 54116 -4
Branches 6768 6768
============================================
- Hits 49973 49967 -6
Misses 2486 2486
- Partials 1661 1663 +2
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.31% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.48% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.00% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.54% <ø> (-0.01%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.57% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/9087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.43% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/9087?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org