You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/08/26 16:21:02 UTC
[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4600
[FLINK-7531] Move Flink legacy rest handler to flink-runtime
## What is the purpose of the change
Moves the existing REST handler from `flink-runtime-web` to `flink-runtime`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink moveLegacyRestHandler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4600
----
commit 7835d0a89c8ecdd5b9661ee8c57a9d63a3ed3742
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-14T13:47:04Z
[FLINK-7522] Add termination future to ClusterEntrypoint
The termination future is completed when the ClusterEntrypoint shuts down. This
allows for easier testing.
commit 2cdf97f824bc62a82e65f4c160b9ad64de446de4
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-16T12:36:13Z
[FLINK-7457] Make Dispatcher highly available
This commit introduces a dispatcher leader election and retrieval service to the
HighAvailabilityServices. Moreover it adds code such that the Dispatcher now takes
part in the leader election process using the afore-mentioned services.
Let Dispatcher participate in leader election
Add test for Dispatcher leader election
commit 04caf85d33ddfc3a4a9b788745b8282c3437d8e2
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-10T08:56:12Z
[FLINK-7409] [web] Make WebRuntimeMonitor reactive
This commit changes the behaviour of the WebRuntimeMonitor to not longer block serving
threads by waiting on the result of futures. Instead the RequestHandler now returns a
CompletableFuture<FullHttpResponse> which is written out to the Netty channel upon
completion. This will improve the performance of our WebRuntimeMonitor.
commit 4fa6dedd95555a2d1a91339ff5effda3bc2bd1d5
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-15T10:00:58Z
[FLINK-7458] Generalize GatewayRetriever for WebRuntimeMonitor
Introduce a generalized GatewayRetriever replacing the JobManagerRetriever. The
GatewayRetriever fulfills the same purpose as the JobManagerRetriever with the
ability to retrieve the gateway for an arbitrary endpoint type.
commit 0f9b2ce77e20f25fc95ddeba98f863b86450a72c
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-15T11:55:47Z
[FLINK-7459] Generalize Flink's redirection logic
Introduce RedirectHandler which can be extended to add redirection functionality to all
SimpleInboundChannelHandlers. This allows to share the same functionality across the
StaticFileServerHandler and the RuntimeMonitorHandlerBase which could now be removed.
In the future, the AbstractRestHandler will also extend the RedirectHandler.
commit 88aed4f7a198b3994271088b8e19558d399ddd9d
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-17T13:04:19Z
[FLINK-7527] [rest] Let AbstractRestHandler extend RedirectHandler
By letting the AbstractRestHandler extend the RedirectHandler, we add redirection
capabilities to the AbstractRestHandler.
commit 9b7de1dc21b771fc10ee1661f34c142e990b424f
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-17T13:25:33Z
[FLINK-7528] Create DispatcherRestEndpoint and integrate with Dispatcher
This commit creates the DispatcherRestEndpoint and integrates it with the
Dispatcher. The DispatcherRestEndpoint is created in the SessionClusterEntrypoint
and its address is passed to the Dispatcher such that it can answer the
requestRestAddress RPC.
commit 5e1d0962e654038894fa376e86b1eeb1565c851b
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-17T14:55:03Z
[FLINK-7529] Retrieve complete REST address from gateway
With this change, the complete REST address (protocol://hostname:port) is retrieved
from the RestfulGateway. That way we decouple the RestHandlers from the underlying
RestServerEndpoint/WebRuntimeMonitor because they no longer have to know whether
HTTPs is enabled or not.
commit 0fdb1b2fc26958f180aa188bcbd5304ce07bbeda
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-18T07:52:30Z
[FLINK-7531] Move Flink legacy rest handler to flink-runtime
Move metrics handlers under o.a.f.runtime.webmonitor.handlers
Move StaticFileServerHandler under o.a.f.runtime.webmonitor.files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4600
---
[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4600#discussion_r139393444
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java ---
@@ -72,14 +72,14 @@ public void testEndpoints() throws Exception {
RestServerEndpointConfiguration serverConfig = RestServerEndpointConfiguration.fromConfiguration(config);
RestClientConfiguration clientConfig = RestClientConfiguration.fromConfiguration(config);
- final String address = "localhost";
--- End diff --
it appears this change belongs into another commit.
---
[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4600#discussion_r139419933
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java ---
@@ -72,14 +72,14 @@ public void testEndpoints() throws Exception {
RestServerEndpointConfiguration serverConfig = RestServerEndpointConfiguration.fromConfiguration(config);
RestClientConfiguration clientConfig = RestClientConfiguration.fromConfiguration(config);
- final String address = "localhost";
--- End diff --
Sorry, this must be a rebasing artifact. Will remove it.
---
[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4600#discussion_r139420901
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTrackerTest.java ---
@@ -80,11 +73,11 @@ public void execute(Runnable runnable) {
ExecutionVertex[] taskVertices = new ExecutionVertex[4];
- ExecutionJobVertex jobVertex = mock(ExecutionJobVertex.class);
- when(jobVertex.getJobId()).thenReturn(new JobID());
--- End diff --
I think these changes are the result of the automatic import optimization.
---
[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4600#discussion_r139393572
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTrackerTest.java ---
@@ -80,11 +73,11 @@ public void execute(Runnable runnable) {
ExecutionVertex[] taskVertices = new ExecutionVertex[4];
- ExecutionJobVertex jobVertex = mock(ExecutionJobVertex.class);
- when(jobVertex.getJobId()).thenReturn(new JobID());
--- End diff --
these changes are all unnecessary.
---
[GitHub] flink issue #4600: [FLINK-7531] Move Flink legacy rest handler to flink-runt...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4600
Thanks for the review @zentol. Once the preceding PRs are merged and Travis gives green light, I would like to merge this PR.
---