You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by sm...@apache.org on 2006/04/20 11:05:30 UTC
svn commit: r395541 -
/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Author: smishura
Date: Thu Apr 20 02:05:28 2006
New Revision: 395541
URL: http://svn.apache.org/viewcvs?rev=395541&view=rev
Log:
tests/api/javax/crypto/CipherTest.java back to exclude test to make test suite pass on Linux
Modified:
incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Modified: incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml?rev=395541&r1=395540&r2=395541&view=diff
==============================================================================
--- incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml (original)
+++ incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml Thu Apr 20 02:05:28 2006
@@ -118,6 +118,9 @@
<batchtest todir="${hy.tests.reports}" haltonfailure="no">
<fileset dir="${hy.crypto.src.test.java}">
<include name="**/*Test.java"/>
+
+ <!-- Harmony exclude list -->
+ <exclude name="tests/api/javax/crypto/CipherTest.java"/>
</fileset>
</batchtest>
</junit>
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Stepan Mishura <st...@gmail.com>.
But doesn't work for me.
-Stepan
On 4/20/06, Mark Hindess wrote:
>
> Without the classpath modifications then it works for me on linux.
> -Mark.
>
>
> On 4/20/06, Stepan Mishura <st...@gmail.com> wrote:
> > On 4/20/06, Mark Hindess wrote:
> > >
> > > Stepan,
> > >
> > > In your original commit for HARMONY-315, you made this change:
> > >
> > > <classpath>
> > > <pathelement path="${hy.crypto.src.test.resources}"/>
> > > </classpath>
> > >
> > > I'm not sure how this relates to this JIRA
> >
> >
> > Right, it was better to separate updates.
> >
> > but it is this that breaks
> > > the test. Why not remove/fix this unrelated change rather than
> > > comment out the otherwise working test?
> >
> >
> > It is not quite correct. The tests passes on Windows but fails on Linux
> -
> > I'm going to investigate the difference. But if I remove these lines
> then it
> > will fail on Windows too.
> >
> > IMHO, we should avoid making unrelated changes in a single commit.
> >
> >
> > Agreed.
> >
> > Thanks,
> > Stepan.
> >
> > Regards,
> > > Mark.
> > >
> > > On 4/20/06, smishura@apache.org <sm...@apache.org> wrote:
> > > > Author: smishura
> > > > Date: Thu Apr 20 02:05:28 2006
> > > > New Revision: 395541
> > > >
> > > > URL: http://svn.apache.org/viewcvs?rev=395541&view=rev
> > > > Log:
> > > > tests/api/javax/crypto/CipherTest.java back to exclude test to make
> test
> > > suite pass on Linux
> > > >
> > > > Modified:
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > >
> > > > Modified:
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > > URL:
> > >
> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml?rev=395541&r1=395540&r2=395541&view=diff
> > > >
> > >
> ==============================================================================
> > > > ---
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > (original)
> > > > +++
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > Thu Apr 20 02:05:28 2006
> > > > @@ -118,6 +118,9 @@
> > > > <batchtest todir="${hy.tests.reports}"
> haltonfailure="no">
> > > > <fileset dir="${hy.crypto.src.test.java}">
> > > > <include name="**/*Test.java"/>
> > > > +
> > > > + <!-- Harmony exclude list -->
> > > > + <exclude
> > > name="tests/api/javax/crypto/CipherTest.java"/>
> > > > </fileset>
> > > > </batchtest>
> > > > </junit>
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Mark Hindess <ma...@googlemail.com>
> > > IBM Java Technology Centre, UK.
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Thanks,
> > Stepan Mishura
> > Intel Middleware Products Division
> >
> > ------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Stepan Mishura <st...@gmail.com>.
Oh, I see - thanks!
- Stepan.
On 4/21/06, Mark Hindess wrote:
>
> But I can't see how. It is a tirvial fix though changing cipherText
> on line 554 to 'ciphertext' to match the case of the checked in file
> name.
>
> -Mark.
>
>
> On 4/21/06, Mark Hindess <ma...@googlemail.com> wrote:
> > It did when I submitted the patch.
> > -Mark.
> >
> > On 4/21/06, Stepan Mishura <st...@gmail.com> wrote:
> > > Hi Mark,
> > >
> > > Do you mean that the test tests/api/javax/crypto/CipherTest.java
> passes on
> > > you linux without classpath modification?
> > >
> > > Thanks,
> > > Stepan.
> > >
> > > On 4/20/06, Mark Hindess <ma...@googlemail.com> wrote:
> > > >
> > > > Without the classpath modifications then it works for me on linux.
> > > > -Mark.
> > > >
> > > >
> > > > On 4/20/06, Stepan Mishura <st...@gmail.com> wrote:
> > > > > On 4/20/06, Mark Hindess wrote:
> > > > > >
> > > > > > Stepan,
> > > > > >
> > > > > > In your original commit for HARMONY-315, you made this change:
> > > > > >
> > > > > > <classpath>
> > > > > > <pathelement path="${hy.crypto.src.test.resources
> }"/>
> > > > > > </classpath>
> > > > > >
> > > > > > I'm not sure how this relates to this JIRA
> > > > >
> > > > >
> > > > > Right, it was better to separate updates.
> > > > >
> > > > > but it is this that breaks
> > > > > > the test. Why not remove/fix this unrelated change rather than
> > > > > > comment out the otherwise working test?
> > > > >
> > > > >
> > > > > It is not quite correct. The tests passes on Windows but fails on
> Linux
> > > > -
> > > > > I'm going to investigate the difference. But if I remove these
> lines
> > > > then it
> > > > > will fail on Windows too.
> > > > >
> > > > > IMHO, we should avoid making unrelated changes in a single commit.
> > > > >
> > > > >
> > > > < SNIP>
> > > >
> > > > --
> > > > Mark Hindess <ma...@googlemail.com>
> > > > IBM Java Technology Centre, UK.
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Thanks,
> > > Stepan Mishura
> > > Intel Middleware Products Division
> > >
> > > ------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Mark Hindess <ma...@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Mark Hindess <ma...@googlemail.com>.
But I can't see how. It is a tirvial fix though changing cipherText
on line 554 to 'ciphertext' to match the case of the checked in file
name.
-Mark.
On 4/21/06, Mark Hindess <ma...@googlemail.com> wrote:
> It did when I submitted the patch.
> -Mark.
>
> On 4/21/06, Stepan Mishura <st...@gmail.com> wrote:
> > Hi Mark,
> >
> > Do you mean that the test tests/api/javax/crypto/CipherTest.java passes on
> > you linux without classpath modification?
> >
> > Thanks,
> > Stepan.
> >
> > On 4/20/06, Mark Hindess <ma...@googlemail.com> wrote:
> > >
> > > Without the classpath modifications then it works for me on linux.
> > > -Mark.
> > >
> > >
> > > On 4/20/06, Stepan Mishura <st...@gmail.com> wrote:
> > > > On 4/20/06, Mark Hindess wrote:
> > > > >
> > > > > Stepan,
> > > > >
> > > > > In your original commit for HARMONY-315, you made this change:
> > > > >
> > > > > <classpath>
> > > > > <pathelement path="${hy.crypto.src.test.resources}"/>
> > > > > </classpath>
> > > > >
> > > > > I'm not sure how this relates to this JIRA
> > > >
> > > >
> > > > Right, it was better to separate updates.
> > > >
> > > > but it is this that breaks
> > > > > the test. Why not remove/fix this unrelated change rather than
> > > > > comment out the otherwise working test?
> > > >
> > > >
> > > > It is not quite correct. The tests passes on Windows but fails on Linux
> > > -
> > > > I'm going to investigate the difference. But if I remove these lines
> > > then it
> > > > will fail on Windows too.
> > > >
> > > > IMHO, we should avoid making unrelated changes in a single commit.
> > > >
> > > >
> > > < SNIP>
> > >
> > > --
> > > Mark Hindess <ma...@googlemail.com>
> > > IBM Java Technology Centre, UK.
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Thanks,
> > Stepan Mishura
> > Intel Middleware Products Division
> >
> > ------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Mark Hindess <ma...@googlemail.com>.
It did when I submitted the patch.
-Mark.
On 4/21/06, Stepan Mishura <st...@gmail.com> wrote:
> Hi Mark,
>
> Do you mean that the test tests/api/javax/crypto/CipherTest.java passes on
> you linux without classpath modification?
>
> Thanks,
> Stepan.
>
> On 4/20/06, Mark Hindess <ma...@googlemail.com> wrote:
> >
> > Without the classpath modifications then it works for me on linux.
> > -Mark.
> >
> >
> > On 4/20/06, Stepan Mishura <st...@gmail.com> wrote:
> > > On 4/20/06, Mark Hindess wrote:
> > > >
> > > > Stepan,
> > > >
> > > > In your original commit for HARMONY-315, you made this change:
> > > >
> > > > <classpath>
> > > > <pathelement path="${hy.crypto.src.test.resources}"/>
> > > > </classpath>
> > > >
> > > > I'm not sure how this relates to this JIRA
> > >
> > >
> > > Right, it was better to separate updates.
> > >
> > > but it is this that breaks
> > > > the test. Why not remove/fix this unrelated change rather than
> > > > comment out the otherwise working test?
> > >
> > >
> > > It is not quite correct. The tests passes on Windows but fails on Linux
> > -
> > > I'm going to investigate the difference. But if I remove these lines
> > then it
> > > will fail on Windows too.
> > >
> > > IMHO, we should avoid making unrelated changes in a single commit.
> > >
> > >
> > < SNIP>
> >
> > --
> > Mark Hindess <ma...@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
>
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Stepan Mishura <st...@gmail.com>.
Hi Mark,
Do you mean that the test tests/api/javax/crypto/CipherTest.java passes on
you linux without classpath modification?
Thanks,
Stepan.
On 4/20/06, Mark Hindess <ma...@googlemail.com> wrote:
>
> Without the classpath modifications then it works for me on linux.
> -Mark.
>
>
> On 4/20/06, Stepan Mishura <st...@gmail.com> wrote:
> > On 4/20/06, Mark Hindess wrote:
> > >
> > > Stepan,
> > >
> > > In your original commit for HARMONY-315, you made this change:
> > >
> > > <classpath>
> > > <pathelement path="${hy.crypto.src.test.resources}"/>
> > > </classpath>
> > >
> > > I'm not sure how this relates to this JIRA
> >
> >
> > Right, it was better to separate updates.
> >
> > but it is this that breaks
> > > the test. Why not remove/fix this unrelated change rather than
> > > comment out the otherwise working test?
> >
> >
> > It is not quite correct. The tests passes on Windows but fails on Linux
> -
> > I'm going to investigate the difference. But if I remove these lines
> then it
> > will fail on Windows too.
> >
> > IMHO, we should avoid making unrelated changes in a single commit.
> >
> >
> < SNIP>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Mark Hindess <ma...@googlemail.com>.
Without the classpath modifications then it works for me on linux.
-Mark.
On 4/20/06, Stepan Mishura <st...@gmail.com> wrote:
> On 4/20/06, Mark Hindess wrote:
> >
> > Stepan,
> >
> > In your original commit for HARMONY-315, you made this change:
> >
> > <classpath>
> > <pathelement path="${hy.crypto.src.test.resources}"/>
> > </classpath>
> >
> > I'm not sure how this relates to this JIRA
>
>
> Right, it was better to separate updates.
>
> but it is this that breaks
> > the test. Why not remove/fix this unrelated change rather than
> > comment out the otherwise working test?
>
>
> It is not quite correct. The tests passes on Windows but fails on Linux -
> I'm going to investigate the difference. But if I remove these lines then it
> will fail on Windows too.
>
> IMHO, we should avoid making unrelated changes in a single commit.
>
>
> Agreed.
>
> Thanks,
> Stepan.
>
> Regards,
> > Mark.
> >
> > On 4/20/06, smishura@apache.org <sm...@apache.org> wrote:
> > > Author: smishura
> > > Date: Thu Apr 20 02:05:28 2006
> > > New Revision: 395541
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=395541&view=rev
> > > Log:
> > > tests/api/javax/crypto/CipherTest.java back to exclude test to make test
> > suite pass on Linux
> > >
> > > Modified:
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > >
> > > Modified:
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > URL:
> > http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml?rev=395541&r1=395540&r2=395541&view=diff
> > >
> > ==============================================================================
> > > ---
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > (original)
> > > +++
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > Thu Apr 20 02:05:28 2006
> > > @@ -118,6 +118,9 @@
> > > <batchtest todir="${hy.tests.reports}" haltonfailure="no">
> > > <fileset dir="${hy.crypto.src.test.java}">
> > > <include name="**/*Test.java"/>
> > > +
> > > + <!-- Harmony exclude list -->
> > > + <exclude
> > name="tests/api/javax/crypto/CipherTest.java"/>
> > > </fileset>
> > > </batchtest>
> > > </junit>
> > >
> > >
> > >
> >
> >
> > --
> > Mark Hindess <ma...@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
>
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Stepan Mishura <st...@gmail.com>.
On 4/20/06, Mark Hindess wrote:
>
> Stepan,
>
> In your original commit for HARMONY-315, you made this change:
>
> <classpath>
> <pathelement path="${hy.crypto.src.test.resources}"/>
> </classpath>
>
> I'm not sure how this relates to this JIRA
Right, it was better to separate updates.
but it is this that breaks
> the test. Why not remove/fix this unrelated change rather than
> comment out the otherwise working test?
It is not quite correct. The tests passes on Windows but fails on Linux -
I'm going to investigate the difference. But if I remove these lines then it
will fail on Windows too.
IMHO, we should avoid making unrelated changes in a single commit.
Agreed.
Thanks,
Stepan.
Regards,
> Mark.
>
> On 4/20/06, smishura@apache.org <sm...@apache.org> wrote:
> > Author: smishura
> > Date: Thu Apr 20 02:05:28 2006
> > New Revision: 395541
> >
> > URL: http://svn.apache.org/viewcvs?rev=395541&view=rev
> > Log:
> > tests/api/javax/crypto/CipherTest.java back to exclude test to make test
> suite pass on Linux
> >
> > Modified:
> >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> >
> > Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > URL:
> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml?rev=395541&r1=395540&r2=395541&view=diff
> >
> ==============================================================================
> > ---
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> (original)
> > +++
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> Thu Apr 20 02:05:28 2006
> > @@ -118,6 +118,9 @@
> > <batchtest todir="${hy.tests.reports}" haltonfailure="no">
> > <fileset dir="${hy.crypto.src.test.java}">
> > <include name="**/*Test.java"/>
> > +
> > + <!-- Harmony exclude list -->
> > + <exclude
> name="tests/api/javax/crypto/CipherTest.java"/>
> > </fileset>
> > </batchtest>
> > </junit>
> >
> >
> >
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Posted by Mark Hindess <ma...@googlemail.com>.
Stepan,
In your original commit for HARMONY-315, you made this change:
<classpath>
<pathelement path="${hy.crypto.src.test.resources}"/>
</classpath>
I'm not sure how this relates to this JIRA but it is this that breaks
the test. Why not remove/fix this unrelated change rather than
comment out the otherwise working test?
IMHO, we should avoid making unrelated changes in a single commit.
Regards,
Mark.
On 4/20/06, smishura@apache.org <sm...@apache.org> wrote:
> Author: smishura
> Date: Thu Apr 20 02:05:28 2006
> New Revision: 395541
>
> URL: http://svn.apache.org/viewcvs?rev=395541&view=rev
> Log:
> tests/api/javax/crypto/CipherTest.java back to exclude test to make test suite pass on Linux
>
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
>
> Modified: incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml?rev=395541&r1=395540&r2=395541&view=diff
> ==============================================================================
> --- incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml (original)
> +++ incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml Thu Apr 20 02:05:28 2006
> @@ -118,6 +118,9 @@
> <batchtest todir="${hy.tests.reports}" haltonfailure="no">
> <fileset dir="${hy.crypto.src.test.java}">
> <include name="**/*Test.java"/>
> +
> + <!-- Harmony exclude list -->
> + <exclude name="tests/api/javax/crypto/CipherTest.java"/>
> </fileset>
> </batchtest>
> </junit>
>
>
>
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org