You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/07/14 12:12:13 UTC

[jira] Created: (HARMONY-873) [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().

[classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream(). 
----------------------------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-873
                 URL: http://issues.apache.org/jira/browse/HARMONY-873
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Andrew Zhang


java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream(). 

Following test reproduces the bug:

    public void test_getOutputStream() throws Exception {
        ServerSocket ss = new ServerSocket(2223);
        Socket s = new Socket("127.0.0.1", 2223);
        ss.accept();
        s.shutdownOutput();
        try {
            s.getOutputStream();
            fail("should throw SocketException");
        } catch (SocketException e) {
            // expected
        }
    }

The test passes against RI and fails against Harmony.

I'll upload a patch to fix this problem soon.

Best regards,
Andrew


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-873) [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-873?page=all ]

George Harley reassigned HARMONY-873:
-------------------------------------

    Assignee: George Harley

> [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-873
>                 URL: http://issues.apache.org/jira/browse/HARMONY-873
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: George Harley
>         Attachments: luni.diff
>
>
> java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream(). 
> Following test reproduces the bug:
>     public void test_getOutputStream() throws Exception {
>         ServerSocket ss = new ServerSocket(2223);
>         Socket s = new Socket("127.0.0.1", 2223);
>         ss.accept();
>         s.shutdownOutput();
>         try {
>             s.getOutputStream();
>             fail("should throw SocketException");
>         } catch (SocketException e) {
>             // expected
>         }
>     }
> The test passes against RI and fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-873) [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-873?page=all ]

Andrew Zhang updated HARMONY-873:
---------------------------------

    Attachment: luni.diff

Hello,

Would you please try my patch?

Thanks!

Best regards,
Andrew

> [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-873
>                 URL: http://issues.apache.org/jira/browse/HARMONY-873
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Attachments: luni.diff
>
>
> java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream(). 
> Following test reproduces the bug:
>     public void test_getOutputStream() throws Exception {
>         ServerSocket ss = new ServerSocket(2223);
>         Socket s = new Socket("127.0.0.1", 2223);
>         ss.accept();
>         s.shutdownOutput();
>         try {
>             s.getOutputStream();
>             fail("should throw SocketException");
>         } catch (SocketException e) {
>             // expected
>         }
>     }
> The test passes against RI and fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-873) [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-873?page=comments#action_12421491 ] 
            
Andrew Zhang commented on HARMONY-873:
--------------------------------------

Hello George,

The fix looks good, thanks!

Best regards,
Andrew

> [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-873
>                 URL: http://issues.apache.org/jira/browse/HARMONY-873
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: George Harley
>         Attachments: luni.diff
>
>
> java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream(). 
> Following test reproduces the bug:
>     public void test_getOutputStream() throws Exception {
>         ServerSocket ss = new ServerSocket(2223);
>         Socket s = new Socket("127.0.0.1", 2223);
>         ss.accept();
>         s.shutdownOutput();
>         try {
>             s.getOutputStream();
>             fail("should throw SocketException");
>         } catch (SocketException e) {
>             // expected
>         }
>     }
> The test passes against RI and fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-873) [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-873?page=all ]

George Harley closed HARMONY-873.
---------------------------------


Verified by Andrew.

> [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-873
>                 URL: http://issues.apache.org/jira/browse/HARMONY-873
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: George Harley
>         Attachments: luni.diff
>
>
> java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream(). 
> Following test reproduces the bug:
>     public void test_getOutputStream() throws Exception {
>         ServerSocket ss = new ServerSocket(2223);
>         Socket s = new Socket("127.0.0.1", 2223);
>         ss.accept();
>         s.shutdownOutput();
>         try {
>             s.getOutputStream();
>             fail("should throw SocketException");
>         } catch (SocketException e) {
>             // expected
>         }
>     }
> The test passes against RI and fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-873) [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-873?page=all ]

George Harley resolved HARMONY-873.
-----------------------------------

    Resolution: Fixed

Hi Andrew, 

Changes committed in revision 421870. Please could you verify that everything has been applied as expected.

Many thanks for this fix. 

Best regards, 
George


> [classlib][luni] java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream().
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-873
>                 URL: http://issues.apache.org/jira/browse/HARMONY-873
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: George Harley
>         Attachments: luni.diff
>
>
> java.net.Socket.getOutputStream should throw SocketException if output has been shutdown by invoking shutdownOutputStream(). 
> Following test reproduces the bug:
>     public void test_getOutputStream() throws Exception {
>         ServerSocket ss = new ServerSocket(2223);
>         Socket s = new Socket("127.0.0.1", 2223);
>         ss.accept();
>         s.shutdownOutput();
>         try {
>             s.getOutputStream();
>             fail("should throw SocketException");
>         } catch (SocketException e) {
>             // expected
>         }
>     }
> The test passes against RI and fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira