You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jolshan (via GitHub)" <gi...@apache.org> on 2023/10/03 23:30:51 UTC
[PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]
jolshan opened a new pull request, #14480:
URL: https://github.com/apache/kafka/pull/14480
I've added details for VerificationFailureRate and VerificationTimeMs.
I considered adding the documentation for the AddPartitionsToTxnVerification metrics, but I noticed that all the request metrics simply listed Produce|FetchConsumer|FetchFollower. If we don't already report the AddPartitionsToTxn request metrics in this file, it doesn't make sense to add the verification variant. (As well as all the other APIs we report)
We can file a followup jira if we want to redo that whole section.
Once we have alignment here, I will cherrypick to 3.6 branch as well as the kafka-site repo.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #14480:
URL: https://github.com/apache/kafka/pull/14480#issuecomment-1747589664
Tests are unrelated 😓 It is a bit worrying we see this large number of failures in Java 11 from time to time.
I may follow up later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on code in PR #14480:
URL: https://github.com/apache/kafka/pull/14480#discussion_r1345351170
##########
docs/ops.html:
##########
@@ -1789,6 +1789,16 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<td>kafka.server:type=transaction-coordinator-metrics,name=partition-load-time-avg</td>
<td>average time, in milliseconds, it took to load transaction metadata from the consumer offset partitions loaded in the last 30 seconds (including time spent waiting for the loading task to be scheduled)</td>
</tr>
+ <tr>
+ <td>Rate of transactional verification errors</td>
+ <td>kafka.server:type=AddPartitionsToTxnManager,name=VerificationFailureRate</td>
+ <td>in steady state 0, but transient errors are expected during rolls and reassignments of the transactional state partition</td>
Review Comment:
We didn't specify what the metric actually measures. Your PR description when you added it has a nice description asL
`Rate of verifications that returned in failure either from the AddPartitionsToTxn API response or through errors in the AddPartitionsToTxnManager. In steady state this metric will report 0, but transient errors are expected during rolls and reassignments of the transactional state partition`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #14480:
URL: https://github.com/apache/kafka/pull/14480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #14480:
URL: https://github.com/apache/kafka/pull/14480#issuecomment-1747252798
Filed https://issues.apache.org/jira/browse/KAFKA-15545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14480:
URL: https://github.com/apache/kafka/pull/14480#issuecomment-1746315640
> If we don't already report the AddPartitionsToTxn request metrics in this file, it doesn't make sense to add the verification variant. (As well as all the other APIs we report)
We can file a followup jira if we want to redo that whole section.
I do think that we need to have an exhaustive list of all metrics available in documentation. Otherwise user may not know existence of certain metrics unless they look into the code. We can choose to do it in a separate JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #14480:
URL: https://github.com/apache/kafka/pull/14480#issuecomment-1747267286
I will open the kafka-site PR shortly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org