You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/01/10 21:10:58 UTC
[GitHub] nifi pull request #1408: NIFI-3291: Upgrade jQuery and plugins
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1408
NIFI-3291: Upgrade jQuery and plugins
- Upgrading jQuery and it's plugins.
- Packaging at build time using npm.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1408.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1408
----
commit 93093bf26c90e42f06cea50a231687d61e019fe1
Author: Matt Gilman <ma...@gmail.com>
Date: 2017-01-10T21:08:55Z
NIFI-3291:
- Upgrading jQuery and it's plugins.
- Packaging at build time using npm.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1408: NIFI-3291: Upgrade jQuery and plugins
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1408
Thanks @mcgilman this has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1408: NIFI-3291: Upgrade jQuery and plugins
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1408
Thanks. Just updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1408: NIFI-3291: Upgrade jQuery and plugins
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1408
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1408: NIFI-3291: Upgrade jQuery and plugins
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1408#discussion_r96442571
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml ---
@@ -710,8 +784,6 @@
<configuration>
<packagingIncludes>
assets/**/*,
- css/reset.css,
- css/reset.css.gz,
css/common-ui.css,
css/common-ui.css.gz,
css/message-page.css,
--- End diff --
We need to add the slick-nifi-theme here:
css/slick-nifi-theme.css,
css/slick-nifi-theme.css.gz,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1408: NIFI-3291: Upgrade jQuery and plugins
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1408
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1408: NIFI-3291: Upgrade jQuery and plugins
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1408
I also noticed there are scrollbars showing up in the "Access Policies" shell as well as the "Add Reporting Task" dialog.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---