You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Davis-Zhang-Onehouse (via GitHub)" <gi...@apache.org> on 2024/07/22 17:40:44 UTC
[PR] [HUDI-8005] Add new lock provider implementation [hudi]
Davis-Zhang-Onehouse opened a new pull request, #11667:
URL: https://github.com/apache/hudi/pull/11667
OSS jira: https://issues.apache.org/jira/browse/HUDI-8005
OSS PR: https://github.com/apache/hudi/compare/master...Davis-Zhang-Onehouse:hudi-oss:hudi-8005
The change adds a new lock provider which is exactly the same as existing dynamoDB based one except the way the partition key part is handled.
Existing one: The parameter is explicitly specified in lock configuration.
New one: It is implicitly derived from the hudi table base path and hudi table name. The 2 attributes are available in todays lockConfig, which contains all props from hudiWriterConfig.
Test:
Unit test and integration test
### Change Logs
Add new lock provider implementation. For code shared by the new-old lock provider, they are extracted to a base class.
Unit test + integration test
### Impact
None.
### Risk level (write none, low medium or high below)
no risk as of now since no one is using the new lock provider.
### Documentation Update
In https://hudi.apache.org/docs/concurrency_control/, we need to add description for the newly added lock provider.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249563347
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
}, {
"hash" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990",
"triggerID" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"triggerType" : "PUSH"
}, {
"hash" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991",
"triggerID" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87e7dd1ce50e523825faefcdb743c58cafd0799d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249079211
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b9c108b939ae4d983581d327a41f7729d6a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954)
* 4067fc0892daecf63f2eed646080c7e3ad6ac406 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986)
* 9d246043864bb1528779cd067baeaeadc9825feb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249243340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
}, {
"hash" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990",
"triggerID" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0d35dd52dbc5783ecae6f4a338e28462e0278a2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2243569746
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 020641e0c7f323b69b4a23da7f457573c2d2160b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2243765016
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b907b18a1718ecb33d2e00cd747d77b20efd17b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951)
* 8b9c108b939ae4d983581d327a41f7729d6a8896 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add a new DynamoDB based lock provider with auto-generated partition key [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #11667:
URL: https://github.com/apache/hudi/pull/11667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249014853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b9c108b939ae4d983581d327a41f7729d6a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954)
* 4067fc0892daecf63f2eed646080c7e3ad6ac406 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2250509756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991",
"triggerID" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87e7dd1ce50e523825faefcdb743c58cafd0799d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2250704416
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991",
"triggerID" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87e7dd1ce50e523825faefcdb743c58cafd0799d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #11667:
URL: https://github.com/apache/hudi/pull/11667#discussion_r1690602593
##########
hudi-aws/src/main/java/org/apache/hudi/config/DynamoDbBasedLockConfig.java:
##########
@@ -43,20 +43,15 @@
+ " are auto managed internally.")
public class DynamoDbBasedLockConfig extends HoodieConfig {
- public static DynamoDbBasedLockConfig.Builder newBuilder() {
- return new DynamoDbBasedLockConfig.Builder();
- }
-
+ public static final int MAX_PARTITION_KEY_SIZE_BYTE = 2048;
// configs for DynamoDb based locks
public static final String DYNAMODB_BASED_LOCK_PROPERTY_PREFIX = LockConfiguration.LOCK_PREFIX + "dynamodb.";
-
Review Comment:
Keep the empty lines?
##########
hudi-aws/src/main/java/org/apache/hudi/config/DynamoDbBasedLockConfig.java:
##########
@@ -140,26 +132,23 @@ public static class Builder {
public DynamoDbBasedLockConfig build() {
lockConfig.setDefaults(DynamoDbBasedLockConfig.class.getName());
- checkRequiredProps(lockConfig);
return lockConfig;
}
public Builder fromProperties(TypedProperties props) {
lockConfig.getProps().putAll(props);
+ checkRequiredProps();
Review Comment:
Should this be in `build()` after line `lockConfig.setDefaults(DynamoDbBasedLockConfig.class.getName());` because `fromProperties` might not be called?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieConfig.java:
##########
@@ -40,14 +40,13 @@
*/
public class HoodieConfig implements Serializable {
- private static final Logger LOG = LoggerFactory.getLogger(HoodieConfig.class);
Review Comment:
Same here, keep the variable ordering?
##########
hudi-aws/src/main/java/org/apache/hudi/config/DynamoDbBasedLockConfig.java:
##########
@@ -43,20 +43,15 @@
+ " are auto managed internally.")
public class DynamoDbBasedLockConfig extends HoodieConfig {
- public static DynamoDbBasedLockConfig.Builder newBuilder() {
- return new DynamoDbBasedLockConfig.Builder();
- }
-
Review Comment:
nit: don't change the order?
##########
hudi-common/src/main/java/org/apache/hudi/common/util/hash/HashID.java:
##########
@@ -30,8 +31,6 @@
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
-import static org.apache.hudi.common.util.StringUtils.getUTF8Bytes;
Review Comment:
Also keep the static import?
##########
hudi-common/src/main/java/org/apache/hudi/common/util/hash/HashID.java:
##########
@@ -41,52 +40,14 @@ public class HashID implements Serializable {
private static final int HASH_SEED = 0xdabadaba;
/**
- * Represents HashID size in bits.
Review Comment:
Same here on the ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249188696
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
}, {
"hash" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990",
"triggerID" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9d246043864bb1528779cd067baeaeadc9825feb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988)
* f0d35dd52dbc5783ecae6f4a338e28462e0278a2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249118367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4067fc0892daecf63f2eed646080c7e3ad6ac406 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986)
* 9d246043864bb1528779cd067baeaeadc9825feb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2250482220
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87e7dd1ce50e523825faefcdb743c58cafd0799d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #11667:
URL: https://github.com/apache/hudi/pull/11667#discussion_r1690606343
##########
hudi-common/src/test/resources/magic_input.txt:
##########
@@ -0,0 +1,10 @@
+vB1xYjlEfL8tN9Ap6NMCwraFQlpQ6QU2z9XCPCv9lfIxzRfs6GfxKir2FuU:Xbl9uMZqjNRhKLqZY2MIH5vPCKZbV1zjoHVaVBnyRfzJLZ0jwWZQjJqjpdg/PsrIq3YdyAsDHcb__oXfbZUpMFX00g6ALt/uRZ2LOFFdQA9Ofuu_BLhhPl4gIfGNJIt1ATuCGIFXFG4zg1qn96MsLy8Nr2v/6pxzBXM5Rhzn6o_HhiFo1RzooJcm1tJlObZroxBNKSDbDcdYkm4KnAVUAVcyVfO2DRx_KQfphLYbG1rNRTV03RNN7jQakMf8Vq38Q1Joz:STilSqalcvrDmdPTY1RETh8eVP0ELqsKevQ22OKKl5ypy4I2Y6nqRfTfoepo_l0zc_QEZNawdif5l:SpvaJUaWU9rpUpqxiz2T_40ekLVXDM_B9oGgS4e9AMT50OASHp/cVue2qFpgrYSptp4EZZ9yfEqPXX3Ij7hSUGL29zarLuur:pY03Qls0tfrddYPxyqxO43dnuqzG:XKV7jQQnbHPjJ4Lq:Z9A3c8Ge6ya8kf_Y1tHlgGTPgRnYZLW//1mKQIXeJBS01rrpgbT6zDJ8Pg__F:8dpU:vZL8JYeMprm/n1xbYAzpXrsuDE7p5B:KOl3gZXLOsozjas8ImKUDkpAkwZtNJckQYfIN5nYcbBCPDMNztyLVVLc1fBCNwsHDCGhK1584o3lKSWVfGlJmaODlvEcW22MqYIKS1zGBr/nN_rjZfsY2glxx7zm8rjzB6ueNuzwB0HtB2Jz53Kt0Xrr0FAE9ZuBIwHzcRZHJTlra67I1AU:KaVq/UOJfAJt42mGd:o6Sj5NV0:nkYZ5KHtbn5AR:1Ri:8w1d3OwWTM7X3qsSBzuB4urbXaBNHOLN:FabK:r4FQSw2rGsaqFiwLO/Zt1fDXBH0pulJ64/6KubP52WN4o89TBaCOCT97PLh:4ttevpa1q_zcFR_VX6RfNvYFDJYC_zC2T
hep
Review Comment:
Could we add these test resource files under `src/test/resources/hash/`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "yehanz (via GitHub)" <gi...@apache.org>.
yehanz commented on code in PR #11667:
URL: https://github.com/apache/hudi/pull/11667#discussion_r1690785307
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieConfig.java:
##########
@@ -42,6 +42,7 @@ public class HoodieConfig implements Serializable {
private static final Logger LOG = LoggerFactory.getLogger(HoodieConfig.class);
+ public static final String BASE_PATH_KEY = "hoodie.base.path";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2243684008
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b907b18a1718ecb33d2e00cd747d77b20efd17b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2243914473
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b9c108b939ae4d983581d327a41f7729d6a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2243585660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 020641e0c7f323b69b4a23da7f457573c2d2160b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249386496
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
}, {
"hash" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990",
"triggerID" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"triggerType" : "PUSH"
}, {
"hash" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0d35dd52dbc5783ecae6f4a338e28462e0278a2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990)
* 87e7dd1ce50e523825faefcdb743c58cafd0799d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249072182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b9c108b939ae4d983581d327a41f7729d6a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954)
* 4067fc0892daecf63f2eed646080c7e3ad6ac406 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986)
* 9d246043864bb1528779cd067baeaeadc9825feb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249497019
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
}, {
"hash" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990",
"triggerID" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"triggerType" : "PUSH"
}, {
"hash" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991",
"triggerID" : "87e7dd1ce50e523825faefcdb743c58cafd0799d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0d35dd52dbc5783ecae6f4a338e28462e0278a2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24990)
* 87e7dd1ce50e523825faefcdb743c58cafd0799d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24991)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2243670987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 020641e0c7f323b69b4a23da7f457573c2d2160b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949)
* 5b907b18a1718ecb33d2e00cd747d77b20efd17b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2243778161
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b907b18a1718ecb33d2e00cd747d77b20efd17b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951)
* 8b9c108b939ae4d983581d327a41f7729d6a8896 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249022611
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b9c108b939ae4d983581d327a41f7729d6a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954)
* 4067fc0892daecf63f2eed646080c7e3ad6ac406 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11667:
URL: https://github.com/apache/hudi/pull/11667#issuecomment-2249124822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24949",
"triggerID" : "020641e0c7f323b69b4a23da7f457573c2d2160b",
"triggerType" : "PUSH"
}, {
"hash" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24951",
"triggerID" : "5b907b18a1718ecb33d2e00cd747d77b20efd17b",
"triggerType" : "PUSH"
}, {
"hash" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24954",
"triggerID" : "8b9c108b939ae4d983581d327a41f7729d6a8896",
"triggerType" : "PUSH"
}, {
"hash" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986",
"triggerID" : "4067fc0892daecf63f2eed646080c7e3ad6ac406",
"triggerType" : "PUSH"
}, {
"hash" : "9d246043864bb1528779cd067baeaeadc9825feb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988",
"triggerID" : "9d246043864bb1528779cd067baeaeadc9825feb",
"triggerType" : "PUSH"
}, {
"hash" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0d35dd52dbc5783ecae6f4a338e28462e0278a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4067fc0892daecf63f2eed646080c7e3ad6ac406 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24986)
* 9d246043864bb1528779cd067baeaeadc9825feb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24988)
* f0d35dd52dbc5783ecae6f4a338e28462e0278a2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8005] Add new lock provider implementation [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #11667:
URL: https://github.com/apache/hudi/pull/11667#discussion_r1690630034
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieConfig.java:
##########
@@ -42,6 +42,7 @@ public class HoodieConfig implements Serializable {
private static final Logger LOG = LoggerFactory.getLogger(HoodieConfig.class);
+ public static final String BASE_PATH_KEY = "hoodie.base.path";
Review Comment:
Forgot to mention, could we use `HoodieCommonConfig.BASE_PATH` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org