You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/10/19 21:20:09 UTC
Review Request 63170: Eliminated unnecssary copying within
process::Mutex.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63170/
-----------------------------------------------------------
Review request for mesos and Zhitao Li.
Repository: mesos
Description
-------
The code prior to this commit was written before Promise had move
support. We no longer need to allocate the waiter Promises on the
heap.
Diffs
-----
3rdparty/libprocess/include/process/mutex.hpp ca8bc67d9dfdffeaab9996fbc1c700c50a416ca7
Diff: https://reviews.apache.org/r/63170/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 63170: Eliminated unnecssary copying within
process::Mutex.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63170/#review188770
-----------------------------------------------------------
Ship it!
Ship It!
- Zhitao Li
On Oct. 19, 2017, 9:20 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63170/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 9:20 p.m.)
>
>
> Review request for mesos and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The code prior to this commit was written before Promise had move
> support. We no longer need to allocate the waiter Promises on the
> heap.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/mutex.hpp ca8bc67d9dfdffeaab9996fbc1c700c50a416ca7
>
>
> Diff: https://reviews.apache.org/r/63170/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 63170: Eliminated unnecssary copying within
process::Mutex.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63170/#review188793
-----------------------------------------------------------
PASS: Mesos patch 63170 was successfully built and tested.
Reviews applied: `['63170']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63170
- Mesos Reviewbot Windows
On Oct. 19, 2017, 2:20 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63170/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 2:20 p.m.)
>
>
> Review request for mesos and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The code prior to this commit was written before Promise had move
> support. We no longer need to allocate the waiter Promises on the
> heap.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/mutex.hpp ca8bc67d9dfdffeaab9996fbc1c700c50a416ca7
>
>
> Diff: https://reviews.apache.org/r/63170/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>