[jira] [Commented] (OPENJPA-2983) Locale-sensitive toUpperCase on temporal field name

["Maxim Solodovnik (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106171#comment-18106171 ] 

Maxim Solodovnik commented on OPENJPA-2983:
-------------------------------------------

[~romain.manni-bucau] there are lots of such cases in the code :( 
(I've updated them all + updated toLowerCase())

The question is: there are lots of places with {{.toUpperCase(Locale.ENGLISH);}} shall it be updated to {{.toUpperCase(Locale.ROOT);}}?

> Locale-sensitive toUpperCase on temporal field name
> ---------------------------------------------------
>
>                 Key: OPENJPA-2983
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2983
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: https://github.com/apache/openjpa/pull/144#discussion_r3683005413
> **(low)** `field.toString().toUpperCase()` is locale-sensitive ("minute" breaks under a Turkish default locale). Prefer `toUpperCase(Locale.ROOT)`, and ideally key off the known LocalDateField/LocalTimeField constants rather than `toString()`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)