You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/08 11:14:46 UTC
[GitHub] [arrow-rs] Jefffrey opened a new pull request, #3491: Fix negative interval prettyprint
Jefffrey opened a new pull request, #3491:
URL: https://github.com/apache/arrow-rs/pull/3491
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Related to https://github.com/apache/arrow-datafusion/issues/4220
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Current issue where nanoseconds/milliseconds part can print the minus sign if negative, which can double up with the seconds, not to mention is incorrectly placed (after the decimal). This fixes it to only have a single sign before the seconds, if negative
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jefffrey commented on pull request #3491: Fix negative interval prettyprint
Posted by GitBox <gi...@apache.org>.
Jefffrey commented on PR #3491:
URL: https://github.com/apache/arrow-rs/pull/3491#issuecomment-1376196459
> Why does this only handle negative seconds, as opposed to negative intervals in general?
For negative intervals in general, the current pretty print works, as will have the negative sign before each part. But special handling is needed for seconds/fractions of a second, as only need to have one sign for the both of them, unlike current behaviour which has a sign for the fractions of a second as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3491: Fix negative interval prettyprint
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3491:
URL: https://github.com/apache/arrow-rs/pull/3491#issuecomment-1377708061
Makes sense, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3491: Fix negative interval prettyprint
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3491:
URL: https://github.com/apache/arrow-rs/pull/3491#issuecomment-1378635836
Benchmark runs are scheduled for baseline = 3788fd20f053ee58f08b4d09cd4dac5bb9b96c06 and contender = 5fb337db04a1a19f7d40da46f19b7b5fd4051593. 5fb337db04a1a19f7d40da46f19b7b5fd4051593 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9ebf822f12f5469ea82ecc00e8056e6f...94f8fa1d448244b8b51317cfeb69d49c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4f12ff3921d9495f9493c66fc5c38288...47353a7192b44542a3c807f118d48664/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9158d15807da4a2cb97c46196935bf56...50a8948c34624233b32b092c2652269d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9613222c709440fa82566f1b427f229c...d3c523efb5304d64a1954e2f2355ebf6/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3491: Fix negative interval prettyprint
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3491:
URL: https://github.com/apache/arrow-rs/pull/3491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org